From: Johannes Schindelin <Johannes.Schindelin@gmx.de> To: Junio C Hamano <firstname.lastname@example.org> Cc: Jeff King <email@example.com>, firstname.lastname@example.org, Emily Shaffer <email@example.com> Subject: Re: [PATCH 3/5] make git-bugreport a builtin Date: Fri, 14 Aug 2020 16:28:37 +0200 (CEST) [thread overview] Message-ID: <nycvar.QRO.firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Hi Junio, On Thu, 13 Aug 2020, Junio C Hamano wrote: > Jeff King <firstname.lastname@example.org> writes: > > > There's no reason that bugreport has to be a separate binary. And since > > it links against libgit.a, it has a rather large disk footprint. Let's > > make it a builtin, which reduces the size of a stripped installation > > from 24MB to 22MB. > > > > This also simplifies our Makefile a bit. And we can take advantage of > > builtin niceties like RUN_SETUP_GENTLY. > > > > Signed-off-by: Jeff King <email@example.com> > > --- > > Makefile | 6 +----- > > builtin.h | 1 + > > bugreport.c => builtin/bugreport.c | 10 +++------- > > contrib/buildsystems/CMakeLists.txt | 5 +---- > > git.c | 1 + > > 5 files changed, 7 insertions(+), 16 deletions(-) > > rename bugreport.c => builtin/bugreport.c (96%) > > I am on the fence, as bugreport does not seem to be fully completed > part of the system. The original thinking was that it may soon want > to grow by linking with platform specific libraries for lower-level > system characteristic identification, at which time we'd not want to > have it in builtins and "we can take advantage of builtin niceties" > will cause us regrets. The only reason that hasn't happened as far > as I can see is because its development speed is rather slow. No, I think the reason is much more benign: my suggestion to query information from the respective executables that _already_ link to said shared libraries seems to have born fruit. It has the additional advantage that we need not worry about cases where `git-bugreport` would look at a different dependency than, say, `git-remote--curl`. So yes, I am rather delighted that `bugreport` finally takes this direction. It makes me much less worried about the reliability of the information provided in bug reports. Ciao, Dscho
next prev parent reply other threads:[~2020-08-14 14:28 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-13 14:55 [PATCH 0/5] slimming down installed size Jeff King 2020-08-13 14:57 ` [PATCH 1/5] Makefile: drop builtins from MSVC pdb list Jeff King 2020-08-13 15:04 ` Taylor Blau 2020-08-13 15:08 ` Jeff King 2020-08-13 16:37 ` Derrick Stolee 2020-08-13 17:40 ` Jeff King 2020-08-14 14:18 ` Johannes Schindelin 2020-08-14 14:32 ` Jeff King 2020-08-17 4:42 ` Johannes Schindelin 2020-08-17 13:20 ` Jeff Hostetler 2020-08-13 14:58 ` [PATCH 2/5] make credential helpers builtins Jeff King 2020-08-13 15:08 ` Taylor Blau 2020-08-13 15:14 ` Jeff King 2020-08-13 17:55 ` Junio C Hamano 2020-08-13 14:59 ` [PATCH 3/5] make git-bugreport a builtin Jeff King 2020-08-13 17:01 ` Derrick Stolee 2020-08-13 17:38 ` Jeff King 2020-08-13 18:25 ` Junio C Hamano 2020-08-13 18:47 ` Junio C Hamano 2020-08-14 10:13 ` Jeff King 2020-08-14 14:25 ` Johannes Schindelin 2020-08-14 10:05 ` Jeff King 2020-08-13 18:01 ` Junio C Hamano 2020-08-14 14:28 ` Johannes Schindelin [this message] 2020-08-15 6:38 ` Jeff King 2020-08-17 12:12 ` Emily Shaffer 2020-08-17 16:58 ` Junio C Hamano 2020-08-17 21:40 ` Jeff King 2020-08-17 12:16 ` Emily Shaffer 2020-08-13 14:59 ` [PATCH 4/5] make git-fast-import " Jeff King 2020-08-13 15:00 ` [PATCH 5/5] drop vcs-svn experiment Jeff King 2020-08-13 15:11 ` Taylor Blau 2020-08-13 15:18 ` Jeff King 2020-08-14 14:39 ` Johannes Schindelin 2020-08-14 15:11 ` Jeff King 2020-08-13 15:13 ` [PATCH 0/5] slimming down installed size Taylor Blau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=nycvar.QRO.firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 3/5] make git-bugreport a builtin' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).