From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] cmake: determine list of extra built-ins dynamically
Date: Fri, 4 Dec 2020 23:44:17 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2012042341270.25979@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <X8qmClPjwYWIoExP@coredump.intra.peff.net>
Hi Peff,
On Fri, 4 Dec 2020, Jeff King wrote:
> On Fri, Dec 04, 2020 at 07:33:56PM +0000, Johannes Schindelin via GitGitGadget wrote:
>
> > Rather than always play catch-up and adjust `git_builtin_extra`
> > manually, use the `BUILT_INS` definitions in the Makefile as
> > authoritative source and generate `git_builtin_extra` dynamically.
>
> Yay. This is exactly how I'd hoped things would work or the cmake file
> in general. I don't mind following micro-formats within our Makefile to
> keep things easier for the cmake parsing side.
Me, too. I am somewhat embarrassed that I missed the `git_builtin_extra`
list in my review of the CMake patch series...
> > contrib/buildsystems/CMakeLists.txt | 15 +++++++++++----
> > 1 file changed, 11 insertions(+), 4 deletions(-)
>
> The implementation looks plausibly correct to me (bearing in mind that
> I've never written cmake).
It is a close copy of the two macros we already use to parse the
`Makefile` for lists of `.o` files and for scripts.
Together with the fact that this patch fixes the CI build of Git for
Windows' `shears/seen` branch (which is a continuously-rebased version of
Git for Windows' `main` branch onto `seen`, plus fixups), I am fairly
confident that it is correct.
Ciao,
Dscho
prev parent reply other threads:[~2020-12-04 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 19:33 [PATCH] cmake: determine list of extra built-ins dynamically Johannes Schindelin via GitGitGadget
2020-12-04 20:10 ` Junio C Hamano
2020-12-04 22:41 ` Johannes Schindelin
2020-12-04 21:11 ` Jeff King
2020-12-04 22:44 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2012042341270.25979@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).