From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: ss/submodule-add-in-c, was Re: What's cooking in git.git (Dec 2020, #05; Mon, 28)
Date: Tue, 5 Jan 2021 16:41:38 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2101051640150.2213@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqeej9g325.fsf@gitster.c.googlers.com>
Hi Junio,
On Mon, 28 Dec 2020, Junio C Hamano wrote:
> * ss/submodule-add-in-c (2020-12-15) 3 commits
> . t7400: add test to check 'submodule add' for tracked paths
> . submodule: port submodule subcommand 'add' from shell to C
> . dir: change the scope of function 'directory_exists_in_index()'
>
> "git submodule add" being rewritten in C.
>
> Expecting a reroll.
> The patches are split incorrectly; part of 1/3 belongs to 2/3
> cf. <nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet>
> It seems to introduce a segfault on 'seen'.
> cf. <xmqqft3xflw7.fsf@gitster.c.googlers.com>
Maybe nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet would be a
better reference, as I diagnosed this issue and provided a patch that
papers over the issue (hoping that the original contributor would not take
it as-is).
Ciao,
Dscho
next prev parent reply other threads:[~2021-01-05 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 19:09 What's cooking in git.git (Dec 2020, #05; Mon, 28) Junio C Hamano
2020-12-29 1:35 ` Felipe Contreras
2021-01-06 5:55 ` Junio C Hamano
2020-12-29 8:32 ` Christian Couder
2021-01-05 15:41 ` Johannes Schindelin [this message]
2021-01-05 22:57 ` ss/submodule-add-in-c, was " Junio C Hamano
2021-01-07 23:23 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2101051640150.2213@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).