Re: [PATCH v2] trailer: allow spaces in tokens

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Christian Couder <christian.couder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Maxwell Bernstein <tekk.nolagi@gmail.com>,
	Max Bernstein via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	Max Bernstein <donotemailthisaddress@bernsteinbear.com>,
	Max Bernstein <max@bernsteinbear.com>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2] trailer: allow spaces in tokens
Date: Mon, 22 Aug 2022 15:58:21 +0200 (CEST)	[thread overview]
Message-ID: <p8srs909-19p5-4o24-r245-roq46pp4s6p5@tzk.qr> (raw)
In-Reply-To: <CAP8UFD2kMXHxvg1tKVNLhY0Gweq2YrD7+tHmZXKwguYzRQ1Qpg@mail.gmail.com>

Hi Christian,

On Fri, 19 Aug 2022, Christian Couder wrote:

> On Fri, Aug 19, 2022 at 6:33 AM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Junio C Hamano <gitster@pobox.com> writes:
> >
> > > but see a room for unrelated improvement from the current code,
> > > namely, to allow exactly one optional space, immediately before the
> > > separator and nowhere else.
> >
> > Ah, no, sorry, I misread the situation.  It's not a room for
> > improvement.  It is very close to what the current code already does,
> > i.e. to allow optional spaces immediately before the separator.  The
> > difference is that the current code allows arbitrary number of
> > optional spaces, not zero or exactly one.
>
> Yeah, I think it makes sense to not change this default behavior, but
> maybe, if people don't like it for some reason, allow options to tweak
> it.

That sounds like a very good compromise to me.

Ciao,
Dscho