From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, avarab@gmail.com,
Derrick Stolee <derrickstolee@github.com>
Subject: [PATCH 0/5] Partial bundle follow ups
Date: Tue, 22 Mar 2022 17:28:34 +0000 [thread overview]
Message-ID: <pull.1186.git.1647970119.gitgitgadget@gmail.com> (raw)
For Junio
=========
This is based on master, which recently took ds/partial-bundles.
There are a couple conflicts with 'seen':
* rc/fetch-refetch adds the "--refetch" option right next to where I remove
an instance of CL_ARG__FILTER.
* tb/cruft-packs updates the add_unseen_recent_objects_to_traversal()
method, but this series changes one call from using "&revs" to using
"revs".
Hopefully these are easy conflicts to resolve.
Series Goals
============
These are a few cleanups that were discussed as part of ds/partial-bundles.
* Patch 1 removes the CL_ARG__FILTER macro.
* Patches 2-3 help parse --filter directly into a revs.filter member
instead of copying it from another filter_options.
* Patches 4-5 add output of the hash function capability in 'git bundle
verify'. It also moves the capability output to the end, since it looks a
bit strange in the current location when there are boundary commits.
Series Non-Goals
================
Some items were discussed that I either attempted and dropped, or delayed
for another series:
* create_bundle() in bundle.c does two commit walks: first to discover the
boundary commits to write into the bundle header, and then another that
happens when constructing the pack-file. It looks like this could be
avoided if there will not be any boundary, but there are additional
checks in write_bundle_refs() that look for the SHOWN bit on the commit
objects in order to determine if a requested ref would be excluded by the
rev-list options. This behavior seems important, so I did not remove it.
* 'git clone --bare partial.bdl" should work when partial.bdl is a partial
bundle. However, this requires changing the way we configure partial
cloned repositories to not rely on a remote in order to understand an
object filter. I'm working on this as a parallel series that will likely
require more discussion than these small cleanups.
* Ævar pointed out some newly-visible memory leaks due to moving the filter
out of a static global. After looking at the recommended change, it seems
that we actually need to be more careful about freeing the revs and not
just revs.filter.
Thanks, -Stolee
Derrick Stolee (5):
list-objects-filter: remove CL_ARG__FILTER
pack-objects: move revs out of get_object_list()
pack-objects: parse --filter directly into revs.filter
bundle: move capabilities to end of 'verify'
bundle: output hash information in 'verify'
Documentation/git-bundle.txt | 10 +++++-----
builtin/fetch-pack.c | 4 ++--
builtin/pack-objects.c | 37 +++++++++++++++++------------------
bundle.c | 11 ++++++-----
list-objects-filter-options.h | 5 +----
revision.c | 4 ++--
t/t6020-bundle-misc.sh | 26 ++++++++++++++++--------
7 files changed, 52 insertions(+), 45 deletions(-)
base-commit: f01e51a7cfd75131b7266131b1f7540ce0a8e5c1
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1186%2Fderrickstolee%2Fpartial-bundle-follow-up-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1186/derrickstolee/partial-bundle-follow-up-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1186
--
gitgitgadget
next reply other threads:[~2022-03-22 17:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 17:28 Derrick Stolee via GitGitGadget [this message]
2022-03-22 17:28 ` [PATCH 1/5] list-objects-filter: remove CL_ARG__FILTER Derrick Stolee via GitGitGadget
2022-03-22 17:28 ` [PATCH 2/5] pack-objects: move revs out of get_object_list() Derrick Stolee via GitGitGadget
2022-03-22 17:28 ` [PATCH 3/5] pack-objects: parse --filter directly into revs.filter Derrick Stolee via GitGitGadget
2022-03-22 19:37 ` [-SPAM-] " Ramsay Jones
2022-03-23 13:48 ` Derrick Stolee
2022-03-22 21:15 ` Ævar Arnfjörð Bjarmason
2022-03-22 17:28 ` [PATCH 4/5] bundle: move capabilities to end of 'verify' Derrick Stolee via GitGitGadget
2022-03-23 7:08 ` Bagas Sanjaya
2022-03-23 13:39 ` Derrick Stolee
2022-03-22 17:28 ` [PATCH 5/5] bundle: output hash information in 'verify' Derrick Stolee via GitGitGadget
2022-03-23 21:27 ` [PATCH 0/5] Partial bundle follow ups Junio C Hamano
2022-03-25 14:25 ` [PATCH] pack-objects: lazily set up "struct rev_info", don't leak Ævar Arnfjörð Bjarmason
2022-03-25 14:57 ` Derrick Stolee
2022-03-25 16:00 ` Ævar Arnfjörð Bjarmason
2022-03-25 16:41 ` Derrick Stolee
2022-03-25 17:34 ` Ævar Arnfjörð Bjarmason
2022-03-25 19:08 ` Derrick Stolee
2022-03-26 0:52 ` Ævar Arnfjörð Bjarmason
2022-03-28 14:04 ` Derrick Stolee
2022-03-25 18:53 ` Junio C Hamano
2022-03-26 1:09 ` Ævar Arnfjörð Bjarmason
2022-03-28 15:43 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-03-28 15:58 ` Derrick Stolee
2022-03-28 17:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1186.git.1647970119.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).