archive mirror
 help / color / mirror / Atom feed
From: "Halil Sen via GitGitGadget" <>
Cc: Paul Mackerras <>,
	Anders Kaseorg <>,
	Junio C Hamano <>,
	Halil Sen <>
Subject: [PATCH 0/2] gitk: include y coord in recorded sash position
Date: Sun, 20 Feb 2022 19:47:34 +0000	[thread overview]
Message-ID: <> (raw)

This PR fixes the issue reported by Anders Kaseorg in 1

6cd80496e9 ("gitk: Resize panes correctly when reducing window size",
2020-10-03) introduces a mechanism to record previously-set sash positions
to make sure that correct values are used while computing resize

However, if we are not using ttk, then sash represents only the x coordinate
and the recorded sash (oldsash) only includes the x coordinate. When we need
to access the y coordinate via the recorded sash position, we generate the
following Application Error popup:

    Error: expected integer but got ""
    expected integer but got ""
    expected integer but got ""
         while executing
    "$win sash place 0 $sash0 [lindex $s0 1]"
         (procedure "resizeclistpanes" line 38)
         invoked from within
    "resizeclistpanes .tf.histframe.pwclist 2818"
         (command bound to event)

To fix this, if we are not using ttk, we append the sash positions with the
y coordinates before recording them to match the use_ttk case.

halilsen (2):
  gitk: trivial indentation fix
  gitk: include y coord in recorded sash position

 gitk-git/gitk | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

base-commit: e6ebfd0e8cbbd10878070c8a356b5ad1b3ca464e
Fetch-It-Via: git fetch pr-git-1219/senhalil/master-v1

             reply	other threads:[~2022-02-20 19:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20 19:47 Halil Sen via GitGitGadget [this message]
2022-02-20 19:47 ` [PATCH 1/2] gitk: trivial indentation fix halilsen via GitGitGadget
2022-02-20 19:47 ` [PATCH 2/2] gitk: include y coord in recorded sash position halilsen via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/2] gitk: include y coord in recorded sash position' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).