From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, johannes.schindelin@gmx.de,
Derrick Stolee <derrickstolee@github.com>
Subject: [PATCH 0/3] Use "allowlist" and "denylist" tree-wide
Date: Wed, 13 Jul 2022 13:20:47 +0000 [thread overview]
Message-ID: <pull.1274.git.1657718450.gitgitgadget@gmail.com> (raw)
The terms "allowlist" and "denylist" are self-defining. One "allows" things
while the other "denies" things.
These are better terms over "whitelist" and "blacklist" which require prior
knowledge of the terms or cultural expectations around what each color
"means".
This series replaces (almost) all uses of these terms with allowlist and
denylist. The only exceptions are in release notes for older Git versions.
There is no meaningful functional change, although one logging message in
daemon.c is changed and I'm unfamiliar with exactly how that might be
consumed.
Some recommend using "blocklist", but I personally prefer "denylist". To me,
"blocking" something seems permanent. "Denying" something seems ephemeral
and related to a specific request being denied due to some (possibly
mutable) state. I'm open to suggestions here. There are many fewer
replacements needed in this case.
I did not make any change to our CodingGuidelines. Hopefully having clear
usage throughout the codebase will be enough to promote using consistent
terminology.
Thanks, -Stolee
Derrick Stolee (3):
Documentation: use allowlist and denylist
t/*: use allowlist
*: use allowlist and denylist
Documentation/git-cvsserver.txt | 2 +-
Documentation/git-daemon.txt | 10 +++++-----
Documentation/git.txt | 2 +-
daemon.c | 8 ++++----
git-cvsserver.perl | 2 +-
sha1dc/sha1.c | 12 ++++++------
t/README | 4 ++--
t/lib-proto-disable.sh | 6 +++---
t/t5812-proto-disable-http.sh | 2 +-
t/t5815-submodule-protos.sh | 4 ++--
t/t9400-git-cvsserver-server.sh | 2 +-
t/test-lib-functions.sh | 2 +-
t/test-lib.sh | 2 +-
transport.c | 8 ++++----
14 files changed, 33 insertions(+), 33 deletions(-)
base-commit: e4a4b31577c7419497ac30cebe30d755b97752c5
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1274%2Fderrickstolee%2Fallow-deny-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1274/derrickstolee/allow-deny-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1274
--
gitgitgadget
next reply other threads:[~2022-07-13 13:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:20 Derrick Stolee via GitGitGadget [this message]
2022-07-13 13:20 ` [PATCH 1/3] Documentation: use allowlist and denylist Derrick Stolee via GitGitGadget
2022-07-13 15:21 ` Jeff King
2022-07-13 18:34 ` Derrick Stolee
2022-07-13 20:20 ` Junio C Hamano
2022-07-13 13:20 ` [PATCH 2/3] t/*: use allowlist Derrick Stolee via GitGitGadget
2022-07-13 13:20 ` [PATCH 3/3] *: use allowlist and denylist Derrick Stolee via GitGitGadget
2022-07-13 13:27 ` Johannes Schindelin
2022-07-13 15:23 ` Jeff King
2022-07-13 13:29 ` [PATCH 0/3] Use "allowlist" and "denylist" tree-wide Johannes Schindelin
2022-07-13 16:18 ` Junio C Hamano
2022-07-13 18:33 ` Derrick Stolee
2022-07-13 20:32 ` Junio C Hamano
2022-07-13 19:42 ` Ævar Arnfjörð Bjarmason
2022-07-13 22:28 ` Junio C Hamano
2022-07-15 2:25 ` Derrick Stolee
2022-07-13 20:02 ` Ævar Arnfjörð Bjarmason
2022-07-15 2:38 ` [PATCH v2 0/3] Remove use of "whitelist" Derrick Stolee via GitGitGadget
2022-07-15 2:38 ` [PATCH v2 1/3] Documentation: remove use of whitelist Derrick Stolee via GitGitGadget
2022-07-15 10:47 ` Ævar Arnfjörð Bjarmason
2022-07-19 14:21 ` Derrick Stolee
2022-07-15 2:38 ` [PATCH v2 2/3] t/*: avoid "whitelist" Derrick Stolee via GitGitGadget
2022-07-15 11:02 ` Ævar Arnfjörð Bjarmason
2022-07-19 15:09 ` Derrick Stolee
2022-07-19 15:26 ` Ævar Arnfjörð Bjarmason
2022-07-19 15:42 ` Derrick Stolee
2022-07-19 19:44 ` Junio C Hamano
2022-07-15 2:38 ` [PATCH v2 3/3] *: " Derrick Stolee via GitGitGadget
2022-07-15 11:19 ` Ævar Arnfjörð Bjarmason
2022-07-15 6:30 ` [PATCH v2 0/3] Remove use of "whitelist" Junio C Hamano
2022-07-15 16:16 ` Phillip Wood
2022-07-19 18:32 ` [PATCH v3 0/5] " Derrick Stolee via GitGitGadget
2022-07-19 18:32 ` [PATCH v3 1/5] daemon: clarify directory arguments Derrick Stolee via GitGitGadget
2022-07-19 18:32 ` [PATCH v3 2/5] git-cvsserver: clarify directory list Derrick Stolee via GitGitGadget
2022-07-19 18:32 ` [PATCH v3 3/5] git.txt: remove redundant language Derrick Stolee via GitGitGadget
2022-07-31 0:35 ` Jeff King
2022-07-19 18:32 ` [PATCH v3 4/5] t: avoid "whitelist" Derrick Stolee via GitGitGadget
2022-07-19 18:32 ` [PATCH v3 5/5] transport.c: " Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1274.git.1657718450.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).