From: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Philippe Blain" <levraiphilippeblain@gmail.com>,
"Denton Liu" <liu.denton@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Phillip Wood" <phillip.wood123@gmail.com>,
"Elijah Newren" <newren@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Phillip Wood" <phillip.wood@dunelm.org.uk>
Subject: [PATCH v4 0/8] rebase --keep-base: imply --reapply-cherry-picks and --no-fork-point
Date: Mon, 17 Oct 2022 13:17:37 +0000 [thread overview]
Message-ID: <pull.1323.v4.git.1666012665.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1323.v3.git.1665650564.gitgitgadget@gmail.com>
A while a go Philippe reported [1] that he was surprised 'git rebase
--keep-base' removed commits that had been cherry-picked upstream even
though to branch was not being rebased. I think it is also surprising if
'--keep-base' changes the base of the branch without '--fork-point' being
explicitly given on the command line. This series therefore changes the
default behavior of '--keep-base' to imply '--reapply-cherry-picks' and
'--no-fork-point' so that the base of the branch is unchanged and no commits
are removed.
Thanks to Junio and Ævar for their comments, the changes since V3 are:
* Patch 3: added lookup_commit_object() that works like
lookup_commit_reference() but without dereferencing tags.
* Patch 4: changed lookup_commit_reference() to lookup_commit_object()
* Patch 5: unchanged - Ævar has concerns about renaming merge_base to
branch_base but I think this is an improvement overall.
* Patches 6 & 8: fixed a whitespace issue
Thanks to Junio for his comments, the changes since V2 are:
* Patch 3 new patch to make sure we're reading hex oids from state files
* Patch 4 restored the call to read_refs() to avoid the dwim behavior of
lookup_commit_reference_by_name()
* Patch 6 added a comment to clarify what a null oid branch_base means
Thanks to everyone who commented for their reviews, the changes since V1
are:
* Patch 1: new patch to tighten a couple of existing tests
* Patch 2: reworded commit message in response to Junio's comments
* Patch 3: fixed a typo in the commit message spotted by Elijah and tidied
code formatting
* Patch 4: new patch to rename a variable suggested by Junio
* Patch 5: clarified commit message and removed some redundant code spotted
by Junio
* Patch 6: improved --reapply-cherry-picks documentation to mention
--keep-base and vice-versa suggested by Philippe
* Patch 7: expanded the commit message and documentation in response to
Junio's comments
[1]
https://lore.kernel.org/git/0EA8C067-5805-40A7-857A-55C2633B8570@gmail.com/
Phillip Wood (8):
t3416: tighten two tests
t3416: set $EDITOR in subshell
rebase: be stricter when reading state files containing oids
rebase: store orig_head as a commit
rebase: rename merge_base to branch_base
rebase: factor out branch_base calculation
rebase --keep-base: imply --reapply-cherry-picks
rebase --keep-base: imply --no-fork-point
Documentation/git-rebase.txt | 32 ++++---
builtin/rebase.c | 144 ++++++++++++++++++-------------
commit.c | 8 ++
commit.h | 13 +++
t/t3416-rebase-onto-threedots.sh | 62 ++++++++++---
t/t3431-rebase-fork-point.sh | 2 +-
6 files changed, 172 insertions(+), 89 deletions(-)
base-commit: afa70145a25e81faa685dc0b465e52b45d2444bd
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1323%2Fphillipwood%2Fwip%2Frebase--keep-base-tweaks-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1323/phillipwood/wip/rebase--keep-base-tweaks-v4
Pull-Request: https://github.com/gitgitgadget/git/pull/1323
Range-diff vs v3:
1: 12fb0ac6d5d = 1: 12fb0ac6d5d t3416: tighten two tests
2: d6f2f716c77 = 2: d6f2f716c77 t3416: set $EDITOR in subshell
3: 1fd58520253 ! 3: 1d5e0419c45 rebase: be stricter when reading state files containing oids
@@ Commit message
The state files for 'onto' and 'orig_head' should contain a full hex
oid, change the reading functions from get_oid() to get_oid_hex() to
- reflect this.
+ reflect this. They should also name commits and not tags so add and use
+ a function that looks up a commit from an oid like
+ lookup_commit_reference() but without dereferencing tags.
Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
@@ builtin/rebase.c: static int read_basic_state(struct rebase_options *opts)
xstrdup(head_name.buf) : NULL;
strbuf_release(&head_name);
- if (get_oid(buf.buf, &oid))
-+ if (get_oid_hex(buf.buf, &oid))
- return error(_("could not get 'onto': '%s'"), buf.buf);
- opts->onto = lookup_commit_or_die(&oid, buf.buf);
+- return error(_("could not get 'onto': '%s'"), buf.buf);
+- opts->onto = lookup_commit_or_die(&oid, buf.buf);
++ if (get_oid_hex(buf.buf, &oid) ||
++ !(opts->onto = lookup_commit_object(the_repository, &oid)))
++ return error(_("invalid onto: '%s'"), buf.buf);
+ /*
+ * We always write to orig-head, but interactive rebase used to write to
@@ builtin/rebase.c: static int read_basic_state(struct rebase_options *opts)
} else if (!read_oneliner(&buf, state_dir_path("head", opts),
READ_ONELINER_WARN_MISSING))
@@ builtin/rebase.c: static int read_basic_state(struct rebase_options *opts)
return error(_("invalid orig-head: '%s'"), buf.buf);
if (file_exists(state_dir_path("quiet", opts)))
+
+ ## commit.c ##
+@@ commit.c: struct commit *lookup_commit_or_die(const struct object_id *oid, const char *ref
+ return c;
+ }
+
++struct commit *lookup_commit_object (struct repository *r,
++ const struct object_id *oid)
++{
++ struct object *obj = parse_object(r, oid);
++ return obj ? object_as_type(obj, OBJ_COMMIT, 0) : NULL;
++
++}
++
+ struct commit *lookup_commit(struct repository *r, const struct object_id *oid)
+ {
+ struct object *obj = lookup_object(r, oid);
+
+ ## commit.h ##
+@@ commit.h: enum decoration_type {
+ void add_name_decoration(enum decoration_type type, const char *name, struct object *obj);
+ const struct name_decoration *get_name_decoration(const struct object *obj);
+
++/*
++ * Look up commit named by "oid" respecting replacement objects.
++ * Returns NULL if "oid" is not a commit or does not exist.
++ */
++struct commit *lookup_commit_object(struct repository *r, const struct object_id *oid);
++
++/*
++ * Look up commit named by "oid" without replacement objects or
++ * checking for object existence. Returns the requested commit if it
++ * is found in the object cache, NULL if "oid" is in the object cache
++ * but is not a commit and a newly allocated unparsed commit object if
++ * "oid" is not in the object cache.
++ */
+ struct commit *lookup_commit(struct repository *r, const struct object_id *oid);
+ struct commit *lookup_commit_reference(struct repository *r,
+ const struct object_id *oid);
4: dc056b13ed5 ! 4: 22f3d265b57 rebase: store orig_head as a commit
@@ Commit message
oid to a commit.
To avoid changing the behavior of "git rebase <upstream> <branch>" we
- keep the existing call to read_ref() and use lookup_commit_reference()
+ keep the existing call to read_ref() and use lookup_commit_object()
on the oid returned by that rather than calling
lookup_commit_reference_by_name() which applies the ref dwim rules to
- its argument. lookup_commit_reference() will dereference tag objects
- but we do not expect the branch being rebased to be pointing to a tag
- object.
+ its argument.
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
@@ builtin/rebase.c: static int read_basic_state(struct rebase_options *opts)
return -1;
- if (get_oid_hex(buf.buf, &opts->orig_head))
+ if (get_oid_hex(buf.buf, &oid) ||
-+ !(opts->orig_head = lookup_commit_reference(the_repository, &oid)))
++ !(opts->orig_head = lookup_commit_object(the_repository, &oid)))
return error(_("invalid orig-head: '%s'"), buf.buf);
if (file_exists(state_dir_path("quiet", opts)))
@@ builtin/rebase.c: int cmd_rebase(int argc, const char **argv, const char *prefix
die_if_checked_out(buf.buf, 1);
options.head_name = xstrdup(buf.buf);
+ options.orig_head =
-+ lookup_commit_reference(the_repository,
-+ &branch_oid);
++ lookup_commit_object(the_repository,
++ &branch_oid);
/* If not is it a valid ref (branch or commit)? */
} else {
- struct commit *commit =
5: 00f70c90344 = 5: 79a8c0fe284 rebase: rename merge_base to branch_base
6: 2efbfc94187 ! 6: bd24409a266 rebase: factor out branch_base calculation
@@ builtin/rebase.c: int cmd_rebase(int argc, const char **argv, const char *prefix
options.onto_name);
+ fill_branch_base(&options, &branch_base);
}
--
+
if (options.fork_point > 0)
- options.restrict_revision =
- get_fork_point(options.upstream_name, options.orig_head);
@@ builtin/rebase.c: int cmd_rebase(int argc, const char **argv, const char *prefix)
* Check if we are already based on onto with linear history,
* in which case we could fast-forward without replacing the commits
7: bc39c76b217 ! 7: 367e44c6928 rebase --keep-base: imply --reapply-cherry-picks
@@ builtin/rebase.c: int cmd_rebase(int argc, const char **argv, const char *prefix
if (gpg_sign)
@@ builtin/rebase.c: int cmd_rebase(int argc, const char **argv, const char *prefix)
- options.onto_name);
fill_branch_base(&options, &branch_base);
}
+
+ if (keep_base && options.reapply_cherry_picks)
+ options.upstream = options.onto;
+
8: 4d0226e1dcc = 8: 656b9c9dab6 rebase --keep-base: imply --no-fork-point
--
gitgitgadget
next prev parent reply other threads:[~2022-10-17 13:17 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 15:11 [PATCH 0/5] rebase --keep-base: imply --reapply-cherry-picks and --no-fork-point Phillip Wood via GitGitGadget
2022-08-15 15:11 ` [PATCH 1/5] t3416: set $EDITOR in subshell Phillip Wood via GitGitGadget
2022-08-15 16:53 ` Junio C Hamano
2022-08-16 13:53 ` Phillip Wood
2022-08-24 22:28 ` Jonathan Tan
2022-08-30 15:12 ` Phillip Wood
2022-08-15 15:11 ` [PATCH 2/5] rebase: store orig_head as a commit Phillip Wood via GitGitGadget
2022-08-15 16:58 ` Junio C Hamano
2022-08-16 9:11 ` Johannes Schindelin
2022-08-18 7:01 ` Elijah Newren
2022-08-15 15:11 ` [PATCH 3/5] rebase: factor out merge_base calculation Phillip Wood via GitGitGadget
2022-08-15 17:22 ` Junio C Hamano
2022-08-16 9:15 ` Johannes Schindelin
2022-08-16 15:00 ` Junio C Hamano
2022-08-16 13:50 ` Phillip Wood
2022-08-16 15:03 ` Junio C Hamano
2022-08-18 7:11 ` Elijah Newren
2022-08-24 22:02 ` Jonathan Tan
2022-08-30 15:03 ` Phillip Wood
2022-08-15 15:11 ` [PATCH 4/5] rebase --keep-base: imply --reapply-cherry-picks Phillip Wood via GitGitGadget
2022-08-15 20:58 ` Junio C Hamano
2022-08-24 22:09 ` Jonathan Tan
2022-08-30 15:09 ` Phillip Wood
2022-08-25 0:29 ` Philippe Blain
2022-09-05 13:54 ` Phillip Wood
2022-08-15 15:11 ` [PATCH 5/5] rebase --keep-base: imply --no-fork-point Phillip Wood via GitGitGadget
2022-08-15 21:07 ` Junio C Hamano
2022-08-24 22:18 ` Jonathan Tan
2022-09-05 13:51 ` Phillip Wood
2022-08-16 9:23 ` [PATCH 0/5] rebase --keep-base: imply --reapply-cherry-picks and --no-fork-point Johannes Schindelin
2022-08-24 22:27 ` Jonathan Tan
2022-09-07 14:37 ` [PATCH v2 0/7] " Phillip Wood via GitGitGadget
2022-09-07 14:37 ` [PATCH v2 1/7] t3416: tighten two tests Phillip Wood via GitGitGadget
2022-09-07 18:12 ` Junio C Hamano
2022-09-07 14:37 ` [PATCH v2 2/7] t3416: set $EDITOR in subshell Phillip Wood via GitGitGadget
2022-09-07 18:12 ` Junio C Hamano
2022-09-07 14:37 ` [PATCH v2 3/7] rebase: store orig_head as a commit Phillip Wood via GitGitGadget
2022-09-07 18:12 ` Junio C Hamano
2022-09-08 13:19 ` Phillip Wood
2022-09-07 14:37 ` [PATCH v2 4/7] rebase: rename merge_base to branch_base Phillip Wood via GitGitGadget
2022-09-07 18:12 ` Junio C Hamano
2022-09-07 14:37 ` [PATCH v2 5/7] rebase: factor out branch_base calculation Phillip Wood via GitGitGadget
2022-09-07 18:12 ` Junio C Hamano
2022-09-07 14:37 ` [PATCH v2 6/7] rebase --keep-base: imply --reapply-cherry-picks Phillip Wood via GitGitGadget
2022-09-07 14:37 ` [PATCH v2 7/7] rebase --keep-base: imply --no-fork-point Phillip Wood via GitGitGadget
2022-09-08 2:44 ` Denton Liu
2022-09-08 13:21 ` Phillip Wood
2022-10-13 8:42 ` [PATCH v3 0/8] rebase --keep-base: imply --reapply-cherry-picks and --no-fork-point Phillip Wood via GitGitGadget
2022-10-13 8:42 ` [PATCH v3 1/8] t3416: tighten two tests Phillip Wood via GitGitGadget
2022-10-13 8:42 ` [PATCH v3 2/8] t3416: set $EDITOR in subshell Phillip Wood via GitGitGadget
2022-10-13 8:42 ` [PATCH v3 3/8] rebase: be stricter when reading state files containing oids Phillip Wood via GitGitGadget
2022-10-13 16:34 ` Junio C Hamano
2022-10-13 19:10 ` Ævar Arnfjörð Bjarmason
2022-10-13 20:13 ` Junio C Hamano
2022-10-13 8:42 ` [PATCH v3 4/8] rebase: store orig_head as a commit Phillip Wood via GitGitGadget
2022-10-13 16:34 ` Junio C Hamano
2022-10-13 20:49 ` Phillip Wood
2022-10-13 23:25 ` Junio C Hamano
2022-10-13 8:42 ` [PATCH v3 5/8] rebase: rename merge_base to branch_base Phillip Wood via GitGitGadget
2022-10-13 19:16 ` Ævar Arnfjörð Bjarmason
2022-10-17 9:49 ` Phillip Wood
2022-10-17 11:27 ` Ævar Arnfjörð Bjarmason
2022-10-17 13:13 ` Phillip Wood
2022-10-17 16:19 ` Ævar Arnfjörð Bjarmason
2022-10-19 15:35 ` Phillip Wood
2022-10-13 8:42 ` [PATCH v3 6/8] rebase: factor out branch_base calculation Phillip Wood via GitGitGadget
2022-10-13 19:21 ` Ævar Arnfjörð Bjarmason
2022-10-17 9:39 ` Phillip Wood
2022-10-17 11:23 ` Ævar Arnfjörð Bjarmason
2022-10-13 8:42 ` [PATCH v3 7/8] rebase --keep-base: imply --reapply-cherry-picks Phillip Wood via GitGitGadget
2022-10-13 8:42 ` [PATCH v3 8/8] rebase --keep-base: imply --no-fork-point Phillip Wood via GitGitGadget
2022-10-17 13:17 ` Phillip Wood via GitGitGadget [this message]
2022-10-17 13:17 ` [PATCH v4 1/8] t3416: tighten two tests Phillip Wood via GitGitGadget
2022-10-17 13:17 ` [PATCH v4 2/8] t3416: set $EDITOR in subshell Phillip Wood via GitGitGadget
2022-10-17 13:17 ` [PATCH v4 3/8] rebase: be stricter when reading state files containing oids Phillip Wood via GitGitGadget
2022-10-17 18:51 ` Junio C Hamano
2022-10-19 15:32 ` Phillip Wood
2022-10-17 13:17 ` [PATCH v4 4/8] rebase: store orig_head as a commit Phillip Wood via GitGitGadget
2022-10-17 13:17 ` [PATCH v4 5/8] rebase: rename merge_base to branch_base Phillip Wood via GitGitGadget
2022-10-17 13:17 ` [PATCH v4 6/8] rebase: factor out branch_base calculation Phillip Wood via GitGitGadget
2022-10-17 13:17 ` [PATCH v4 7/8] rebase --keep-base: imply --reapply-cherry-picks Phillip Wood via GitGitGadget
2022-10-17 13:17 ` [PATCH v4 8/8] rebase --keep-base: imply --no-fork-point Phillip Wood via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1323.v4.git.1666012665.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=levraiphilippeblain@gmail.com \
--cc=liu.denton@gmail.com \
--cc=newren@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).