git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: AEvar Bjarmason <avarab@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/1] Make t2024 NO_PERL-safe
Date: Thu, 23 Aug 2018 07:41:23 -0700 (PDT)	[thread overview]
Message-ID: <pull.20.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.20.git.gitgitgadget@gmail.com>

While trying to run the build & test with NO_PERL, I noticed that t2024 had
a failing test case. This patch works around that failing test case by
skipping it when we know that the error message looks different than that
test case would expect.

Changes since v1 (which did not make it to the list due to 
https://github.com/gitgitgadget/gitgitgadget/issues/29):

 * reworded the commit message slightly.

Johannes Schindelin (1):
  t2024: mark a `checkout -p` test as requiring Perl

 t/t2024-checkout-dwim.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


base-commit: 8d7b558baebe3abbbad4973ce1e1f87a7da17f47
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-20%2Fdscho%2Fcheckout-default-remote-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-20/dscho/checkout-default-remote-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/20

Range-diff vs v1:

 1:  619d7bcc31 ! 1:  8d46b31f5a t2024: mark a `checkout -p` test as requiring Perl
     @@ -3,9 +3,11 @@
          t2024: mark a `checkout -p` test as requiring Perl
      
          A recently-added test case tries to verify that the output of `checkout
     -    -p` contains a certain piece of advice. But if Git was built without
     -    Perl and therefore lacks support for `git add -i`, the error output
     -    contains the hint that `-p` is not even available instead.
     +    -p` contains a certain piece of advice.
     +
     +    But if Git was built without Perl and therefore lacks support for `git
     +    add -i`, the error output contains the hint that `-p` is not even
     +    available instead.
      
          Let's just skip that test case altogether if Git was built with NO_PERL.
      

-- 
gitgitgadget

       reply	other threads:[~2018-08-23 14:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <pull.20.git.gitgitgadget@gmail.com>
2018-08-23 14:41 ` Johannes Schindelin via GitGitGadget [this message]
2018-08-23 14:41   ` [PATCH v2 1/1] t2024: mark a `checkout -p` test as requiring Perl Johannes Schindelin via GitGitGadget
2018-08-23 15:00     ` Ævar Arnfjörð Bjarmason
2018-08-23 20:59       ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.20.v2.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).