From: "Ben Keene via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Ben Keene <seraphire@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/3] Feature: New Variable git-p4.p4program
Date: Fri, 15 Nov 2019 14:42:55 +0000 [thread overview]
Message-ID: <pull.465.v2.git.1573828978.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.465.git.1573679665.gitgitgadget@gmail.com>
Issue: Using git-p4.py on Windows does not resolve properly to the p4.exe
binary in all instances.
Changes since v1: Commit: (dc6817e) 2019-11-14
Renamed the variable "git-p4.binary" to "git-p4.p4program" per the thread
discussion.
v1:
Two new code features are added to resolve the p4 executable location:
1. A new variable, git-p4.binary, has been added that takes precedence over
the default p4 executable name. If this git option is set and the
path.exists() passes for this file it will be used as executable for the
system.popen calls.
2. If the new variable git-p4.binary is not set, the program checks if the
operating system is Windows. If it is, the executable is changed to
'p4.exe'. All other operating systems
(those that do not report 'Windows' in the platform.system() call)
continue to use the current executable of 'p4'.
Ben Keene (3):
Cast byte strings to unicode strings in python3
Added general variable git-p4.binary and added a default for windows
of 'P4.EXE'
Changed the name of the parameter from git-p4.binary to
git-p4.p4program
Documentation/git-p4.txt | 5 +++++
git-p4.py | 40 +++++++++++++++++++++++++++++++++++++---
2 files changed, 42 insertions(+), 3 deletions(-)
base-commit: d9f6f3b6195a0ca35642561e530798ad1469bd41
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-465%2Fseraphire%2Fseraphire%2Fp4-binary-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-465/seraphire/seraphire/p4-binary-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/465
Range-diff vs v1:
1: 0bca930ff8 = 1: 0bca930ff8 Cast byte strings to unicode strings in python3
2: 98bae92fda = 2: 98bae92fda Added general variable git-p4.binary and added a default for windows of 'P4.EXE'
-: ---------- > 3: dc6817eea3 Changed the name of the parameter from git-p4.binary to git-p4.p4program
--
gitgitgadget
next prev parent reply other threads:[~2019-11-15 14:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:14 [PATCH 0/2] Feature: New Variable git-p4.binary Ben Keene via GitGitGadget
2019-11-13 21:14 ` [PATCH 1/2] Cast byte strings to unicode strings in python3 Ben Keene via GitGitGadget
2019-11-13 21:14 ` [PATCH 2/2] Added general variable git-p4.binary and added a default for windows of 'P4.EXE' Ben Keene via GitGitGadget
2019-11-14 2:36 ` [PATCH 0/2] Feature: New Variable git-p4.binary Junio C Hamano
2019-11-14 9:53 ` Luke Diamand
2019-11-14 20:16 ` Ben Keene
2019-11-15 9:28 ` Luke Diamand
2019-11-15 14:42 ` Ben Keene via GitGitGadget [this message]
2019-11-15 14:42 ` [PATCH v2 1/3] Cast byte strings to unicode strings in python3 Ben Keene via GitGitGadget
2019-11-16 2:40 ` Junio C Hamano
2019-11-16 3:52 ` Junio C Hamano
2019-11-15 14:42 ` [PATCH v2 2/3] Added general variable git-p4.binary and added a default for windows of 'P4.EXE' Ben Keene via GitGitGadget
2019-11-16 2:50 ` Junio C Hamano
2019-11-15 14:42 ` [PATCH v2 3/3] Changed the name of the parameter from git-p4.binary to git-p4.p4program Ben Keene via GitGitGadget
2019-11-16 2:40 ` [PATCH v2 0/3] Feature: New Variable git-p4.p4program Junio C Hamano
2019-11-18 1:15 ` Junio C Hamano
2019-12-03 15:59 ` Ben Keene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.465.v2.git.1573828978.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=seraphire@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).