From: "Jorge via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jorge <JALopezSilva@gmail.com>
Subject: [PATCH 0/2] Add HTTPS proxy SSL options (cert, key, cainfo)
Date: Fri, 21 Feb 2020 21:36:41 +0000 [thread overview]
Message-ID: <pull.559.git.1582321003.gitgitgadget@gmail.com> (raw)
Git currently supports connecting to proxies through HTTPS. However it does
not allow you to configure SSL options when connecting (i.e. client cert,
key, cainfo). These set of commits add the necessary options and
documentation needed to support them.
Libcurl already has support for this so changes are somewhat minimal.
I didn't see integration tests under /t or tests that verified libcurl
integration. Is there another recommended way to add unit tests for these
changes? I did verify manually with an HTTPS proxy that the options were
having the desired effect.
./bin-wrappers/git -c http.proxy=https://<PROXY-HOSTNAME> \
-c http.proxycert=<CERT> -c http.proxykey=<KEY> \
clone https://github.com/jalopezsilva/dotfiles.git
Jorge Lopez Silva (2):
http: add client cert for HTTPS proxies.
config: documentation for HTTPS proxy client cert.
Documentation/config/http.txt | 14 ++++++++++
http.c | 48 ++++++++++++++++++++++++++++++++---
2 files changed, 59 insertions(+), 3 deletions(-)
base-commit: 51ebf55b9309824346a6589c9f3b130c6f371b8f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-559%2Fjalopezsilva%2Fhttps_proxy_ssl_options-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-559/jalopezsilva/https_proxy_ssl_options-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/559
--
gitgitgadget
next reply other threads:[~2020-02-21 21:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 21:36 Jorge via GitGitGadget [this message]
2020-02-21 21:36 ` [PATCH 1/2] http: add client cert for HTTPS proxies Jorge Lopez Silva via GitGitGadget
2020-02-21 22:28 ` Eric Sunshine
2020-02-26 21:05 ` Jorge A López Silva
2020-02-21 21:36 ` [PATCH 2/2] config: documentation for HTTPS proxy client cert Jorge Lopez Silva via GitGitGadget
2020-02-26 23:23 ` [PATCH v2 0/2] Add HTTPS proxy SSL options (cert, key, cainfo) Jorge via GitGitGadget
2020-02-26 23:23 ` [PATCH v2 1/2] http: add client cert for HTTPS proxies Jorge Lopez Silva via GitGitGadget
2020-02-27 18:31 ` Junio C Hamano
2020-03-03 1:41 ` Jorge A López Silva
2020-02-26 23:23 ` [PATCH v2 2/2] config: documentation for HTTPS proxy client cert Jorge Lopez Silva via GitGitGadget
2020-02-27 18:58 ` Junio C Hamano
2020-03-03 1:47 ` Jorge A López Silva
2020-03-04 18:40 ` [PATCH v3 0/2] Add HTTPS proxy SSL options (cert, key, cainfo) Jorge via GitGitGadget
2020-03-04 18:40 ` [PATCH v3 1/2] http: add client cert for HTTPS proxies Jorge Lopez Silva via GitGitGadget
2020-03-04 18:40 ` [PATCH v3 2/2] http: add environment variable for HTTPS proxy Jorge Lopez Silva via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.559.git.1582321003.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=JALopezSilva@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).