From: "Ben Keene via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Ben Keene <seraphire@gmail.com>
Subject: [PATCH v3 0/5] git-p4: add hook p4-pre-edit-changelist
Date: Thu, 06 Feb 2020 15:15:43 +0000 [thread overview]
Message-ID: <pull.698.v3.git.git.1581002149.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.698.v2.git.git.1580507895.gitgitgadget@gmail.com>
Our company's workflow requires that our P4 check-in messages have a
specific format. A helpful feature in the GIT-P4 program would be a hook
that occurs after the P4 change list is created but before it is displayed
in the editor that would allow an external program to possibly edit the
changelist text.
v1:My suggestion for the hook name is p4-pre-edit-changelist.
It would take a single parameter, the full path of the temporary file. If
the hook returns a non-zero exit code, it would cancel the current P4
submit.
The hook should be optional.
v2:Instead of a single hook, p4-pre-edit-changelist, follow the git
convention for hook names and add the trio of hooks that work together,
similar to git commit.
The hook names are:
* p4-prepare-changelist
* p4-changelist
* p4-post-changelist
The hooks should follow the same convention as git commit, so a new command
line option for the git-p4 submit function --no-verify should also be added.
v3:2-Feb-2020 This version reorganizes the commits to be easier to read. The
function for running the git hook has been rewritten to include suggestions.
This version no longer restricts the executable supported by windows for the
hook. It will first look for a file with the hook name without an extension
and if found, it will pass it to sh.exe (Git for Window's MINGW shell)
Otherwise it will take the file with the lowest alphabetical extension and
ask Windows to execute the program.
Ben Keene (5):
git-p4: rewrite prompt to be Windows compatible
git-p4: create new function run_git_hook
git-p4: add --no-verify option
git-p4: restructure code in submit
git-p4: add p4 submit hooks
Documentation/git-p4.txt | 45 +++++++-
Documentation/githooks.txt | 51 ++++++++-
git-p4.py | 226 ++++++++++++++++++++++++++++---------
3 files changed, 264 insertions(+), 58 deletions(-)
base-commit: de93cc14ab7e8db7645d8dbe4fd2603f76d5851f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-698%2Fseraphire%2Fseraphire%2Fp4-hook-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-698/seraphire/seraphire/p4-hook-v3
Pull-Request: https://github.com/git/git/pull/698
Range-diff vs v2:
1: 585bdd51b2 = 1: 8881d76c46 git-p4: rewrite prompt to be Windows compatible
2: f1f9fdc542 ! 2: 85918a7edb git-p4: create new method gitRunHook
@@ -1,22 +1,22 @@
Author: Ben Keene <seraphire@gmail.com>
- git-p4: create new method gitRunHook
+ git-p4: create new function run_git_hook
This commit is in preparation of introducing new p4 submit hooks.
The current code in the python script git-p4.py makes the assumption
- that the git hooks can be executed by subprocess.call() method. However,
- when git is run on Windows, this may not work as expected.
+ that the git hooks can be executed by subprocess.call() function.
+ However, when git is run on Windows, this may not work as expected.
- The subprocess.call() does not execute SH.EXE implictly under Windows,
- so the scripts may fail. In other words, the hooks do not execute under
- windows because the shell interpreter is not automatically loaded.
+ The subprocess.call() does not cover all the use cases for properly
+ executing the various types of executable files on Windows.
- Add a new function, gitRunHook, that takes 2 parameters:
- * the filename of an optionally registered git hook
+ Prepare for remediation by adding a new function, run_git_hook, that
+ takes 2 parameters:
+ * the short filename of an optionally registered git hook
* an optional list of parameters
- The gitRunHook function will honor the existing behavior seen in the
+ The run_git_hook function will honor the existing behavior seen in the
current code for executing the p4-pre-submit hook:
* Hooks are looked for in core.hooksPath directory.
@@ -28,15 +28,32 @@
return True.
* If the hook returns a non-zero exit code, the function returns False.
- Add new conditional behavior for Windows:
- * Check for an evironment variable 'EXEPATH' which should be set by
- git when git-p4.py is envoked.
- * If EXEPATH is None - treat it as an empty string.
- * If EXEPATH is set, look for sh.exe in the bin/ directory located
- in EXEPATH.
- * If EXEPATH is not set, attempt to resolve against "bin/sh.exe"
- * Add a new test for Windows that checks to see of sh.exe can be
- located. If not, return True.
+ Add the following additional functionality if git-p4.py is run on
+ Windows.
+ * If hook file is not located without an extension, search for
+ any file in the associated hook directory (from the list above) that
+ has the same name but with an extension.
+ * If the file is still not found, return True (the hook is missing)
+
+ Add a new function run_hook_command() that wraps the OS dependent
+ functionality for actually running the subprocess.call() with OS
+ dependent behavior:
+
+ If a hook file exists on Windows:
+ * If there is no extension, set the launch executable to be SH.EXE
+ - Look for SH.EXE under the environmental variable EXEPATH in the
+ bin/ directory.
+ - If %EXEPATH%/bin/sh.exe exists, use this as the actual executable.
+ - If %EXEPATH%/bin/sh.exe does not exist, use sh.exe
+ - Execute subprocess.call() without the shell (shell=False)
+ * If there is an extension, execute subprocess.call() with teh shell
+ (shell=True) and consider the file to be the executable.
+
+ The return value from run_hook_command() is the subprocess.call()
+ return value.
+
+ These functions are added in this commit, but are only staged and not
+ yet used.
Signed-off-by: Ben Keene <seraphire@gmail.com>
@@ -44,10 +61,18 @@
--- a/git-p4.py
+++ b/git-p4.py
@@
- "unshelve" : P4Unshelve,
- }
+ import zlib
+ import ctypes
+ import errno
++import glob
-+def gitRunHook(cmd, param=[]):
+ # support basestring in python3
+ try:
+@@
+ if response in choices:
+ return response
+
++def run_git_hook(cmd, param=[]):
+ """Execute a hook if the hook exists."""
+ if verbose:
+ sys.stderr.write("Looking for hook: %s\n" % cmd)
@@ -57,25 +82,65 @@
+ if len(hooks_path) <= 0:
+ hooks_path = os.path.join(os.environ.get("GIT_DIR", ".git"), "hooks")
+
-+ hook_file = os.path.join(hooks_path, cmd)
-+ if isinstance(param,basestring):
++ if not isinstance(param, list):
+ param=[param]
+
++ # resolve hook file name, OS depdenent
++ hook_file = os.path.join(hooks_path, cmd)
+ if platform.system() == 'Windows':
-+ exepath = os.environ.get("EXEPATH")
-+ if exepath is None:
-+ exepath = ""
-+ shexe = os.path.join(exepath, "bin", "sh.exe")
-+ if os.path.isfile(shexe) \
-+ and os.path.isfile(hook_file) \
-+ and os.access(hook_file, os.X_OK) \
-+ and subprocess.call([shexe, hook_file] + param) != 0:
-+ return False
++ if not os.path.isfile(hook_file):
++ # look for the file with an extension
++ files = glob.glob(hook_file + ".*")
++ if not files:
++ return True
++ files.sort()
++ hook_file = files[0]
++
++ if not os.path.isfile(hook_file) or not os.access(hook_file, os.X_OK):
++ return True
+
-+ else:
-+ if os.path.isfile(hook_file) and os.access(hook_file, os.X_OK) and subprocess.call([hook_file] + param) != 0:
-+ return False
-+ return True
++ return run_hook_command(hook_file, param) == 0
++
++def run_hook_command(cmd, param):
++ """Executes a git hook command
++ cmd = the command line file to be executed. This can be
++ a file that is run by OS association.
++
++ param = a list of parameters to pass to the cmd command
++
++ On windows, the extension is checked to see if it should
++ be run with the Git for Windows Bash shell. If there
++ is no file extension, the file is deemed a bash shell
++ and will be handed off to sh.exe. Otherwise, Windows
++ will be called with the shell to handle the file assocation.
++
++ For non Windows operating systems, the file is called
++ as an executable.
++ """
++ cli = [cmd] + param
++ use_shell = False
++ if platform.system() == 'Windows':
++ (root,ext) = os.path.splitext(cmd)
++ if ext == "":
++ exe_path = os.environ.get("EXEPATH")
++ if exe_path is None:
++ exe_path = ""
++ else:
++ exe_path = os.path.join(exe_path, "bin")
++ cli = [os.path.join(exe_path, "SH.EXE")] + cli
++ else:
++ use_shell = True
++ return subprocess.call(cli, shell=use_shell)
++
++
+ def write_pipe(c, stdin):
+ if verbose:
+ sys.stderr.write('Writing pipe: %s\n' % str(c))
+@@
+ "unshelve" : P4Unshelve,
+ }
+-
def main():
if len(sys.argv[1:]) == 0:
+ printUsage(commands.keys())
-: ---------- > 3: b538ad08b6 git-p4: add --no-verify option
3: 1bdcdc4c18 ! 4: 662b864d70 git-p4: add hook p4-pre-edit-changelist
@@ -1,23 +1,38 @@
Author: Ben Keene <seraphire@gmail.com>
- git-p4: add hook p4-pre-edit-changelist
+ git-p4: restructure code in submit
- Add an additional hook to the git-p4 command to allow a hook to modify
- the text of the changelist prior to displaying the p4editor command.
+ In preparation for adding new hooks to the submit method of git-p4,
+ restructure the applyCommit function in the P4Submit class. Make the
+ following changes:
- This hook will be called prior to checking for the flag
- "--prepare-p4-only".
+ * Move all the code after the definition of submitted = False into the
+ Try-Finally block. This ensures that any error that occurs will
+ properly recover. This is not necessary with the current code because
+ none of it should throw an exception, however the next set of changes
+ will introduce exceptional code.
- The hook is optional, if it does not exist, it will be skipped.
+ Existing flow control can remain as defined - the if-block for
+ prepare-p4-only sets the local variable "submitted" to True and exits
+ the function. New early exits, leave submitted set to False so the
+ Finally block will undo changes to the P4 workspace.
- The hook takes a single parameter, the filename of the temporary file
- that contains the P4 submit text.
+ * Make the small usability change of adding an empty string to the
+ print statements displayed to the user when the prepare-p4-only option
+ is selected. On Windows, the command print() may display a set of
+ parentheses "()" to the user when the print() function is called with
+ no parameters. By supplying an empty string, the intended blank line
+ will print as expected.
- The hook should return a zero exit code on success or a non-zero exit
- code on failure. If the hook returns a non-zero exit code, git-p4
- will revert the P4 edits by calling p4_revert(f) on each file that was
- flagged as edited and then it will return False so the calling method
- may continue as it does in existing failure cases.
+ * Fix a small bug when the submittedTemplate is edited by the user
+ and all content in the file is removed. The existing code will throw
+ an exception if the separateLine is not found in the file. Change this
+ code to test for the separator line using a find() test first and only
+ split on the separator if it is found.
+
+ * Additionally, add the new behavior that if the changelist file has
+ been completely emptied that the Submit action for this changelist
+ will be aborted.
Signed-off-by: Ben Keene <seraphire@gmail.com>
@@ -28,17 +43,126 @@
tmpFile.write(submitTemplate)
tmpFile.close()
-+ # Run the pre-edit hook to allow programmatic update to the changelist
-+ hooks_path = gitConfig("core.hooksPath")
-+ if len(hooks_path) <= 0:
-+ hooks_path = os.path.join(os.environ.get("GIT_DIR", ".git"), "hooks")
+- if self.prepare_p4_only:
+- #
+- # Leave the p4 tree prepared, and the submit template around
+- # and let the user decide what to do next
+- #
+- print()
+- print("P4 workspace prepared for submission.")
+- print("To submit or revert, go to client workspace")
+- print(" " + self.clientPath)
+- print()
+- print("To submit, use \"p4 submit\" to write a new description,")
+- print("or \"p4 submit -i <%s\" to use the one prepared by" \
+- " \"git p4\"." % fileName)
+- print("You can delete the file \"%s\" when finished." % fileName)
+-
+- if self.preserveUser and p4User and not self.p4UserIsMe(p4User):
+- print("To preserve change ownership by user %s, you must\n" \
+- "do \"p4 change -f <change>\" after submitting and\n" \
+- "edit the User field.")
+- if pureRenameCopy:
+- print("After submitting, renamed files must be re-synced.")
+- print("Invoke \"p4 sync -f\" on each of these files:")
+- for f in pureRenameCopy:
+- print(" " + f)
+-
+- print()
+- print("To revert the changes, use \"p4 revert ...\", and delete")
+- print("the submit template file \"%s\"" % fileName)
+- if filesToAdd:
+- print("Since the commit adds new files, they must be deleted:")
+- for f in filesToAdd:
+- print(" " + f)
+- print()
+- return True
+-
+- #
+- # Let the user edit the change description, then submit it.
+- #
+ submitted = False
+
+ try:
++
++ if self.prepare_p4_only:
++ #
++ # Leave the p4 tree prepared, and the submit template around
++ # and let the user decide what to do next
++ #
++ submitted = True
++ print("")
++ print("P4 workspace prepared for submission.")
++ print("To submit or revert, go to client workspace")
++ print(" " + self.clientPath)
++ print("")
++ print("To submit, use \"p4 submit\" to write a new description,")
++ print("or \"p4 submit -i <%s\" to use the one prepared by" \
++ " \"git p4\"." % fileName)
++ print("You can delete the file \"%s\" when finished." % fileName)
+
-+ hook_file = os.path.join(hooks_path, "p4-pre-edit-changelist")
-+ if os.path.isfile(hook_file) and os.access(hook_file, os.X_OK) and subprocess.call([hook_file, fileName]) != 0:
-+ for f in editedFiles:
-+ p4_revert(f)
-+ return False
++ if self.preserveUser and p4User and not self.p4UserIsMe(p4User):
++ print("To preserve change ownership by user %s, you must\n" \
++ "do \"p4 change -f <change>\" after submitting and\n" \
++ "edit the User field.")
++ if pureRenameCopy:
++ print("After submitting, renamed files must be re-synced.")
++ print("Invoke \"p4 sync -f\" on each of these files:")
++ for f in pureRenameCopy:
++ print(" " + f)
++
++ print("")
++ print("To revert the changes, use \"p4 revert ...\", and delete")
++ print("the submit template file \"%s\"" % fileName)
++ if filesToAdd:
++ print("Since the commit adds new files, they must be deleted:")
++ for f in filesToAdd:
++ print(" " + f)
++ print("")
++ sys.stdout.flush()
++ return True
++
+ if self.edit_template(fileName):
+ # read the edited message and submit
+ tmpFile = open(fileName, "rb")
+@@
+ tmpFile.close()
+ if self.isWindows:
+ message = message.replace("\r\n", "\n")
+- submitTemplate = message[:message.index(separatorLine)]
++ if message.find(separatorLine) <> -1:
++ submitTemplate = message[:message.index(separatorLine)]
++ else:
++ submitTemplate = message
+
- if self.prepare_p4_only:
- #
- # Leave the p4 tree prepared, and the submit template around
++ if len(submitTemplate.strip()) == 0:
++ print("Changelist is empty, aborting this changelist.")
++ sys.stdout.flush()
++ return False
+
+ if update_shelve:
+ p4_write_pipe(['shelve', '-r', '-i'], submitTemplate)
+@@
+ submitted = True
+
+ finally:
+- # skip this patch
++ # Revert changes if we skip this patch
+ if not submitted or self.shelve:
+ if self.shelve:
+ print ("Reverting shelved files.")
+ else:
+ print ("Submission cancelled, undoing p4 changes.")
++ sys.stdout.flush()
+ for f in editedFiles | filesToDelete:
+ p4_revert(f)
+ for f in filesToAdd:
+ p4_revert(f)
+ os.remove(f)
+
+- os.remove(fileName)
++ if not self.prepare_p4_only:
++ os.remove(fileName)
+ return submitted
+
+ # Export git tags as p4 labels. Create a p4 label and then tag
4: 3d34dd042e ! 5: e34c377066 git-p4: add p4 submit hooks
@@ -4,19 +4,11 @@
The git command "commit" supports a number of hooks that support
changing the behavior of the commit command. The git-p4.py program only
- has one existing hook, "p4-p4-pre-submit". This command occurs early
- in the process. There are no hooks in the process flow for modifying
+ has one existing hook, "p4-pre-submit". This command occurs early in
+ the process. There are no hooks in the process flow for modifying
the P4 changelist text programmatically.
- Adds 3 new hooks and 1 new option to git-p4.py to the submit option.
-
- The new command line option --no-verify:
-
- Add a new command line option "--no-verify" to the Submit command of
- git-p4.py. This option will function in the spirit of the existing
- --no-verify command line option found in git commit. It will cause the
- P4 Submit function to ignore the existing p4-pre-submit and the new
- p4-changelist hooks.
+ Adds 3 new hooks to git-p4.py to the submit option.
The new hooks are:
* p4-prepare-changelist - Execute this hook after the changelist file
@@ -34,62 +26,16 @@
executed regardless of the --no-verify option. It's return value will
not be checked.
- Change the execution of the existing trigger p4-pre-submit to honor the
- --no-verify option. Before exiting on failure of this hook, display
- text to the user explaining which hook has failed and the impact
- of using the --no-verify option.
-
- Move all the code after creating the submitTemplate text into the
- try-finally block in the applyCommit() method. By restructuring the
- code, the P4 workspace is protected against otherwise unhandled
- exceptions and other early exits.
-
The calls to the new hooks: p4-prepare-changelist, p4-changelist,
and p4-post-changelist should all be called inside the try-finally
block.
- Existing flow control can remain as defined - the if-block for
- prepare-p4-only sets the local variable "submitted" to True and exits
- the function. All other early exits, leave submitted set to False so the
- Finally block will undo changes to the P4 workspace.
-
- Make the small usability change of adding an empty string to the
- print statements displayed to the user when the prepare-p4-only option
- is selected. On Windows, the command print() may display a set of
- parentheses () to the user when the print() function is called with no
- parameters. By supplying an empty string, the intended blank line will
- print as expected.
-
- Fix a small bug when the submittedTemplate is edited by the user
- and all content in the file is removed. The existing code will throw
- an exception if the separateLine is not found in the file. Change this
- code to test for the separator line using a find() test first and only
- split on the separator if it is found.
-
- Additionally, add the new behavior that if the changelist file has been
- completely emptied that the Submit action for this changelist will be
- aborted.
-
Signed-off-by: Ben Keene <seraphire@gmail.com>
diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt
--- a/Documentation/git-p4.txt
+++ b/Documentation/git-p4.txt
@@
- been submitted. Implies --disable-rebase. Can also be set with
- git-p4.disableP4Sync. Sync with origin/master still goes ahead if possible.
-
--Hook for submit
--~~~~~~~~~~~~~~~
-+Hooks for submit
-+----------------
-+
-+p4-pre-submit
-+~~~~~~~~~~~~~
-+
- The `p4-pre-submit` hook is executed if it exists and is executable.
- The hook takes no parameters and nothing from standard input. Exiting with
- non-zero status from this script prevents `git-p4 submit` from launching.
One usage scenario is to run unit tests in the hook.
@@ -128,10 +74,9 @@
+git p4 submit action.
+
+
-+
+
Rebase options
~~~~~~~~~~~~~~
- These options can be used to modify 'git p4 rebase' behavior.
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
--- a/Documentation/githooks.txt
@@ -194,24 +139,18 @@
--- a/git-p4.py
+++ b/git-p4.py
@@
- "work from a local git branch that is not master"),
optparse.make_option("--disable-p4sync", dest="disable_p4sync", action="store_true",
help="Skip Perforce sync of p4/master after submit or shelve"),
-+ optparse.make_option("--no-verify", dest="no_verify", action="store_true",
+ optparse.make_option("--no-verify", dest="no_verify", action="store_true",
+- help="Bypass p4-pre-submit"),
+ help="Bypass p4-pre-submit and p4-changelist hooks"),
]
self.description = """Submit changes from git to the perforce depot.\n
-- The `p4-pre-submit` hook is executed if it exists and is executable.
-- The hook takes no parameters and nothing from standard input. Exiting with
-- non-zero status from this script prevents `git-p4 submit` from launching.
--
-- One usage scenario is to run unit tests in the hook."""
-+ The `p4-pre-submit` hook is executed if it exists and is executable. It
-+ can be bypassed with the `--no-verify` command line option. The hook takes
-+ no parameters and nothing from standard input. Exiting with a non-zero status
-+ from this script prevents `git-p4 submit` from launching.
-+
-+ One usage scenario is to run unit tests in the hook.
+ The `p4-pre-submit` hook is executed if it exists and is executable. It
+@@
+ from this script prevents `git-p4 submit` from launching.
+
+ One usage scenario is to run unit tests in the hook.
+
+ The `p4-prepare-changelist` hook is executed right after preparing the default
+ changelist message and before the editor is started. It takes one parameter,
@@ -234,137 +173,26 @@
+ The `p4-post-changelist` hook is invoked after the submit has successfully
+ occured in P4. It takes no parameters and is meant primarily for notification
+ and cannot affect the outcome of the git p4 submit action.
-+ """
+ """
self.usage += " [name of git branch to submit into perforce depot]"
- self.origin = ""
@@
- self.exportLabels = False
- self.p4HasMoveCommand = p4_has_move_command()
- self.branch = None
-+ self.no_verify = False
-
- if gitConfig('git-p4.largeFileSystem'):
- die("Large file system not supported for git-p4 submit command. Please remove it from config.")
-@@
- applyPatchCmd = patchcmd + "--check --apply -"
- patch_succeeded = True
-
-+ if verbose:
-+ print("TryPatch: %s" % tryPatchCmd)
-+
- if os.system(tryPatchCmd) != 0:
- fixed_rcs_keywords = False
- patch_succeeded = False
-@@
- print("Retrying the patch with RCS keywords cleaned up")
- if os.system(tryPatchCmd) == 0:
- patch_succeeded = True
-+ print("Patch succeesed this time")
-
- if not patch_succeeded:
- for f in editedFiles:
-@@
- tmpFile.write(submitTemplate)
- tmpFile.close()
-
-- # Run the pre-edit hook to allow programmatic update to the changelist
-- hooks_path = gitConfig("core.hooksPath")
-- if len(hooks_path) <= 0:
-- hooks_path = os.path.join(os.environ.get("GIT_DIR", ".git"), "hooks")
--
-- hook_file = os.path.join(hooks_path, "p4-pre-edit-changelist")
-- if os.path.isfile(hook_file) and os.access(hook_file, os.X_OK) and subprocess.call([hook_file, fileName]) != 0:
-- for f in editedFiles:
-- p4_revert(f)
-- return False
--
-- if self.prepare_p4_only:
-- #
-- # Leave the p4 tree prepared, and the submit template around
-- # and let the user decide what to do next
-- #
-- print()
-- print("P4 workspace prepared for submission.")
-- print("To submit or revert, go to client workspace")
-- print(" " + self.clientPath)
-- print()
-- print("To submit, use \"p4 submit\" to write a new description,")
-- print("or \"p4 submit -i <%s\" to use the one prepared by" \
-- " \"git p4\"." % fileName)
-- print("You can delete the file \"%s\" when finished." % fileName)
--
-- if self.preserveUser and p4User and not self.p4UserIsMe(p4User):
-- print("To preserve change ownership by user %s, you must\n" \
-- "do \"p4 change -f <change>\" after submitting and\n" \
-- "edit the User field.")
-- if pureRenameCopy:
-- print("After submitting, renamed files must be re-synced.")
-- print("Invoke \"p4 sync -f\" on each of these files:")
-- for f in pureRenameCopy:
-- print(" " + f)
--
-- print()
-- print("To revert the changes, use \"p4 revert ...\", and delete")
-- print("the submit template file \"%s\"" % fileName)
-- if filesToAdd:
-- print("Since the commit adds new files, they must be deleted:")
-- for f in filesToAdd:
-- print(" " + f)
-- print()
-- return True
--
-- #
-- # Let the user edit the change description, then submit it.
-- #
submitted = False
try:
+ # Allow the hook to edit the changelist text before presenting it
+ # to the user.
-+ if not gitRunHook("p4-prepare-changelist", [fileName]):
++ if not run_git_hook("p4-prepare-changelist", [fileName]):
+ return False
-+
-+ if self.prepare_p4_only:
-+ #
-+ # Leave the p4 tree prepared, and the submit template around
-+ # and let the user decide what to do next
-+ #
-+ submitted = True
-+ print("")
-+ print("P4 workspace prepared for submission.")
-+ print("To submit or revert, go to client workspace")
-+ print(" " + self.clientPath)
-+ print("")
-+ print("To submit, use \"p4 submit\" to write a new description,")
-+ print("or \"p4 submit -i <%s\" to use the one prepared by" \
-+ " \"git p4\"." % fileName)
-+ print("You can delete the file \"%s\" when finished." % fileName)
-+
-+ if self.preserveUser and p4User and not self.p4UserIsMe(p4User):
-+ print("To preserve change ownership by user %s, you must\n" \
-+ "do \"p4 change -f <change>\" after submitting and\n" \
-+ "edit the User field.")
-+ if pureRenameCopy:
-+ print("After submitting, renamed files must be re-synced.")
-+ print("Invoke \"p4 sync -f\" on each of these files:")
-+ for f in pureRenameCopy:
-+ print(" " + f)
-+
-+ print("")
-+ print("To revert the changes, use \"p4 revert ...\", and delete")
-+ print("the submit template file \"%s\"" % fileName)
-+ if filesToAdd:
-+ print("Since the commit adds new files, they must be deleted:")
-+ for f in filesToAdd:
-+ print(" " + f)
-+ print("")
-+ sys.stdout.flush()
-+ return True
-+
+
+ if self.prepare_p4_only:
+ #
+@@
+ return True
+
if self.edit_template(fileName):
+ if not self.no_verify:
-+ if not gitRunHook("p4-changelist", [fileName]):
++ if not run_git_hook("p4-changelist", [fileName]):
+ print("The p4-changelist hook failed.")
+ sys.stdout.flush()
+ return False
@@ -372,64 +200,11 @@
# read the edited message and submit
tmpFile = open(fileName, "rb")
message = tmpFile.read()
- tmpFile.close()
- if self.isWindows:
- message = message.replace("\r\n", "\n")
-- submitTemplate = message[:message.index(separatorLine)]
-+ if message.find(separatorLine) <> -1:
-+ submitTemplate = message[:message.index(separatorLine)]
-+ else:
-+ submitTemplate = message
-+
-+ if len(submitTemplate.strip()) == 0:
-+ print("Changelist is empty, aborting this changelist.")
-+ sys.stdout.flush()
-+ return False
-
- if update_shelve:
- p4_write_pipe(['shelve', '-r', '-i'], submitTemplate)
@@
submitted = True
-+ gitRunHook("p4-post-changelist")
++ run_git_hook("p4-post-changelist")
finally:
-- # skip this patch
-+ # Revert changes if we skip this patch
+ # Revert changes if we skip this patch
if not submitted or self.shelve:
- if self.shelve:
- print ("Reverting shelved files.")
- else:
- print ("Submission cancelled, undoing p4 changes.")
-+ sys.stdout.flush()
- for f in editedFiles | filesToDelete:
- p4_revert(f)
- for f in filesToAdd:
- p4_revert(f)
- os.remove(f)
-
-- os.remove(fileName)
-+ os.remove(fileName)
- return submitted
-
- # Export git tags as p4 labels. Create a p4 label and then tag
-@@
- sys.exit("number of commits (%d) must match number of shelved changelist (%d)" %
- (len(commits), num_shelves))
-
-- hooks_path = gitConfig("core.hooksPath")
-- if len(hooks_path) <= 0:
-- hooks_path = os.path.join(os.environ.get("GIT_DIR", ".git"), "hooks")
--
-- hook_file = os.path.join(hooks_path, "p4-pre-submit")
-- if os.path.isfile(hook_file) and os.access(hook_file, os.X_OK) and subprocess.call([hook_file]) != 0:
-- sys.exit(1)
-+ if not self.no_verify:
-+ if not gitRunHook("p4-pre-submit"):
-+ print("\nThe p4-pre-submit hook failed, aborting the submit.\n\nYou can skip " \
-+ "this pre-submission check by adding\nthe command line option '--no-verify', " \
-+ "however,\nthis will also skip the p4-changelist hook as well.")
-+ sys.exit(1)
-
- #
- # Apply the commits, one at a time. On failure, ask if should
--
gitgitgadget
next prev parent reply other threads:[~2020-02-06 15:15 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 21:17 [PATCH] git-p4: Add hook p4-pre-pedit-changelist Ben Keene via GitGitGadget
2020-01-21 23:05 ` Junio C Hamano
2020-01-29 10:13 ` Luke Diamand
2020-01-29 19:05 ` Junio C Hamano
2020-01-29 21:23 ` Luke Diamand
2020-01-30 1:37 ` Junio C Hamano
2020-01-30 14:20 ` Ben Keene
2020-01-30 18:39 ` Junio C Hamano
2020-01-30 1:51 ` Bryan Turner
2020-01-30 13:45 ` Ben Keene
2020-01-31 21:58 ` [PATCH v2 0/4] git-p4: add hook p4-pre-edit-changelist Ben Keene via GitGitGadget
2020-01-31 21:58 ` [PATCH v2 1/4] git-p4: rewrite prompt to be Windows compatible Ben Keene via GitGitGadget
2020-01-31 21:58 ` [PATCH v2 2/4] git-p4: create new method gitRunHook Ben Keene via GitGitGadget
2020-02-04 20:40 ` Junio C Hamano
2020-02-05 19:56 ` Ben Keene
2020-02-05 21:42 ` Junio C Hamano
2020-02-06 14:00 ` Ben Keene
2020-02-06 18:26 ` Junio C Hamano
2020-01-31 21:58 ` [PATCH v2 3/4] git-p4: add hook p4-pre-edit-changelist Ben Keene via GitGitGadget
2020-01-31 21:58 ` [PATCH v2 4/4] git-p4: add p4 submit hooks Ben Keene via GitGitGadget
2020-02-04 20:50 ` Junio C Hamano
2020-02-06 15:15 ` Ben Keene via GitGitGadget [this message]
2020-02-06 15:15 ` [PATCH v3 1/5] git-p4: rewrite prompt to be Windows compatible Ben Keene via GitGitGadget
2020-02-06 19:28 ` Junio C Hamano
2020-02-10 15:49 ` Ben Keene
2020-02-06 15:15 ` [PATCH v3 2/5] git-p4: create new function run_git_hook Ben Keene via GitGitGadget
2020-02-06 19:42 ` Junio C Hamano
2020-02-10 19:03 ` Ben Keene
2020-02-06 15:15 ` [PATCH v3 3/5] git-p4: add --no-verify option Ben Keene via GitGitGadget
2020-02-06 19:42 ` Junio C Hamano
2020-02-10 16:21 ` Ben Keene
2020-02-06 15:15 ` [PATCH v3 4/5] git-p4: restructure code in submit Ben Keene via GitGitGadget
2020-02-06 15:15 ` [PATCH v3 5/5] git-p4: add p4 submit hooks Ben Keene via GitGitGadget
2020-02-10 22:06 ` [PATCH v4 0/6] git-p4: add hooks for p4-changelist Ben Keene via GitGitGadget
2020-02-10 22:06 ` [PATCH v4 1/6] git-p4: rewrite prompt to be Windows compatible Ben Keene via GitGitGadget
2020-02-10 22:06 ` [PATCH v4 2/6] git-p4: create new function run_git_hook Ben Keene via GitGitGadget
2020-02-10 22:24 ` Junio C Hamano
2020-02-10 22:06 ` [PATCH v4 3/6] git-p4: add --no-verify option Ben Keene via GitGitGadget
2020-02-10 22:06 ` [PATCH v4 4/6] git-p4: restructure code in submit Ben Keene via GitGitGadget
2020-02-10 22:06 ` [PATCH v4 5/6] git-p4: add p4 submit hooks Ben Keene via GitGitGadget
2020-02-10 22:06 ` [PATCH v4 6/6] git-4: add RCS keyword status message Ben Keene via GitGitGadget
2020-02-11 18:57 ` [PATCH v5 0/7] git-p4: add hooks for p4-changelist Ben Keene via GitGitGadget
2020-02-11 18:57 ` [PATCH v5 1/7] git-p4: rewrite prompt to be Windows compatible Ben Keene via GitGitGadget
2020-02-11 18:57 ` [PATCH v5 2/7] git-p4: create new function run_git_hook Ben Keene via GitGitGadget
2020-02-11 18:58 ` [PATCH v5 3/7] git-p4: add p4-pre-submit exit text Ben Keene via GitGitGadget
2020-02-11 18:58 ` [PATCH v5 4/7] git-p4: add --no-verify option Ben Keene via GitGitGadget
2020-02-11 18:58 ` [PATCH v5 5/7] git-p4: restructure code in submit Ben Keene via GitGitGadget
2020-02-11 18:58 ` [PATCH v5 6/7] git-p4: add p4 submit hooks Ben Keene via GitGitGadget
2020-02-11 18:58 ` [PATCH v5 7/7] git-p4: add RCS keyword status message Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 0/7] git-p4: add hooks for p4-changelist Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 1/7] git-p4: rewrite prompt to be Windows compatible Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 2/7] git-p4: create new function run_git_hook Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 3/7] git-p4: add p4-pre-submit exit text Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 4/7] git-p4: add --no-verify option Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 5/7] git-p4: restructure code in submit Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 6/7] git-p4: add p4 submit hooks Ben Keene via GitGitGadget
2020-02-14 14:44 ` [PATCH v6 7/7] git-p4: add RCS keyword status message Ben Keene via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.698.v3.git.git.1581002149.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=seraphire@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).