From: Ibrahim El <ibrahim.el@pm.me>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 0/5] New signing interface API with pluggable drivers
Date: Tue, 27 Aug 2019 18:49:37 +0000 [thread overview]
Message-ID: <roBm3J_8ZgID_Uc8ZPZ8rJP0Ljc4ChC5MD9MGGbYIjQISuzvRxM36ZwcPcWQlKydxl-mwVT7tWWnA01ZGLhqdENo5ljEHkmfkIq3trGBM2k=@pm.me> (raw)
In-Reply-To: <20190826231543.GD11334@genre.crustytoothpaste.net>
Thx for your feedback. I will incorporate the config based improach into a generic driver and will re-submit the patches.
Ibrahim El
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, August 26, 2019 11:15 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:
> On 2019-08-26 at 19:57:45, Ibrahim El wrote:
>
> > Following previous introduction mail 1, this first series of 5 patches is a re-write of the signing interface API in an effort to support easily the addition of new tools with minimal effort and also keeping backwards compatibility with current tools and configuration.
> > All existing tests currently pass with backward compatibility.
> > The patches are ordered as follow:
> > [1/5] - Adding Documentation files explaining the different changes using a design document and updates to the configuration part
> > [2/5] - Adding new files that define the signing interface API and also drivers for the existing GPG and GPGSM X.509 tools
> > [3/5] - Migrating the code to using the new signing interface API. Old GPG Interface code is commented and ommited
> > [4/5] - Removing the old GPG interface and updating the code to remove all gpg mentions from it to make it transparent to the signing tool that is being used
> > [5/5] - Duplicating existing signature related tests and updating them to using the new configuration aliases
>
> I haven't done an in-depth review of this series, but I did point out a
> few things that stood out to me. I think the consensus on the list in
> the past was that for adding future tools, we'd like the drivers to be
> configuration-based so that Git need not learn about every signing tool.
> I think such a change would be welcome if done right.
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> brian m. carlson: Houston, Texas, US
> OpenPGP: https://keybase.io/bk2204
prev parent reply other threads:[~2019-08-27 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 19:57 [PATCH 0/5] New signing interface API with pluggable drivers Ibrahim El
2019-08-26 23:15 ` brian m. carlson
2019-08-27 18:49 ` Ibrahim El [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='roBm3J_8ZgID_Uc8ZPZ8rJP0Ljc4ChC5MD9MGGbYIjQISuzvRxM36ZwcPcWQlKydxl-mwVT7tWWnA01ZGLhqdENo5ljEHkmfkIq3trGBM2k=@pm.me' \
--to=ibrahim.el@pm.me \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).