From: Fredrik Kuivinen <frekui@gmail.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Shawn Pearce <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v2] Make xmalloc and xrealloc thread-safe
Date: Wed, 7 Apr 2010 18:13:18 +0200 [thread overview]
Message-ID: <v2t4c8ef71004070913r2de3c8car31f39a2ab7aa6d15@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1004071103341.7232@xanadu.home>
On Wed, Apr 7, 2010 at 17:08, Nicolas Pitre <nico@fluxnic.net> wrote:
> On Wed, 7 Apr 2010, Fredrik Kuivinen wrote:
>> diff --git a/thread-utils.c b/thread-utils.c
>> index 4f9c829..3c8d817 100644
>> --- a/thread-utils.c
>> +++ b/thread-utils.c
>> @@ -1,4 +1,5 @@
>> #include "cache.h"
>> +#include <pthread.h>
>
> This will fail compilation on Windows surely?
I think it will work. We use "#include <pthread.h>" in builtin/grep.c,
builtin/pack-objects.c, and preload-index.c already.
>> #if defined(hpux) || defined(__hpux) || defined(_hpux)
>> # include <sys/pstat.h>
>> @@ -43,3 +44,24 @@ int online_cpus(void)
>>
>> return 1;
>> }
>> +
>> +int init_recursive_mutex(pthread_mutex_t *m)
>> +{
>> +#ifdef _WIN32
>> + /* The mutexes in the WIN32 pthreads emulation layer are
>> + * recursive, so we don't have to do anything extra here. */
>> + return pthread_mutex_init(m, NULL);
>> +#else
>> + pthread_mutexattr_t a;
>> + int ret;
>> + if (pthread_mutexattr_init(&a))
>> + die("pthread_mutexattr_init failed: %s", strerror(errno));
>> +
>> + if (pthread_mutexattr_settype(&a, PTHREAD_MUTEX_RECURSIVE))
>> + die("pthread_mutexattr_settype failed: %s", strerror(errno));
>> +
>> + ret = pthread_mutex_init(m, &a);
>> + pthread_mutexattr_destroy(&a);
>> + return ret;
>
> Are you sure the pthread_mutexattr_t object can be destroyed even if the
> mutex is still in use? Is the attribute object "attached" to the mutex
> or merely used as a template?
It is safe. See
http://www.opengroup.org/onlinepubs/009695399/functions/pthread_mutexattr_init.html
- Fredrik
next prev parent reply other threads:[~2010-04-07 16:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100323161713.3183.57927.stgit@fredrik-laptop>
2010-03-23 17:31 ` [PATCH 1/2] Make xmalloc and xrealloc thread-safe Fredrik Kuivinen
2010-03-23 18:43 ` Shawn O. Pearce
2010-03-23 21:21 ` Fredrik Kuivinen
2010-03-23 23:50 ` Nicolas Pitre
2010-03-24 15:23 ` Fredrik Kuivinen
2010-03-24 17:53 ` Nicolas Pitre
2010-03-24 18:22 ` Shawn Pearce
2010-03-24 18:44 ` Junio C Hamano
2010-03-24 18:54 ` Nicolas Pitre
2010-03-24 19:57 ` Shawn Pearce
2010-03-24 20:22 ` [PATCH] " Nicolas Pitre
2010-03-24 20:28 ` Shawn O. Pearce
2010-03-24 21:02 ` Nicolas Pitre
2010-03-24 21:11 ` Junio C Hamano
2010-03-24 21:28 ` Junio C Hamano
2010-03-27 13:26 ` Fredrik Kuivinen
2010-03-27 18:59 ` Nicolas Pitre
2010-03-31 6:57 ` Fredrik Kuivinen
2010-04-07 2:57 ` [PATCH v2] " Nicolas Pitre
2010-04-07 3:16 ` Shawn O. Pearce
2010-04-07 4:51 ` Nicolas Pitre
2010-04-07 12:29 ` Shawn Pearce
2010-04-07 13:17 ` Nicolas Pitre
2010-04-07 14:30 ` Shawn Pearce
2010-04-07 14:47 ` Nicolas Pitre
2010-04-07 14:45 ` Fredrik Kuivinen
2010-04-07 15:08 ` Nicolas Pitre
2010-04-07 16:13 ` Fredrik Kuivinen [this message]
2010-04-07 16:44 ` Erik Faye-Lund
2010-04-07 18:37 ` Nicolas Pitre
2010-04-07 15:27 ` Sverre Rabbelier
2010-04-07 16:15 ` Fredrik Kuivinen
2010-04-07 16:17 ` Junio C Hamano
2010-04-07 18:49 ` Johannes Sixt
2010-04-08 7:15 ` [PATCH] Thread-safe xmalloc and xrealloc needs a recursive mutex Johannes Sixt
2010-04-08 8:42 ` Fredrik Kuivinen
2010-04-07 5:21 ` [PATCH v2] Make xmalloc and xrealloc thread-safe Junio C Hamano
2010-03-23 17:31 ` [PATCH 2/2] Make sha1_to_hex thread-safe Fredrik Kuivinen
2010-03-23 20:23 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v2t4c8ef71004070913r2de3c8car31f39a2ab7aa6d15@mail.gmail.com \
--to=frekui@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=nico@fluxnic.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).