From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Richard Weinberger <richard@nod.at>,
Philip Oakley <philipoakley@iee.org>,
git@vger.kernel.org
Subject: Re: [DONOTAPPLY PATCH 2/3] setup: warn about implicit worktree with $GIT_DIR
Date: Wed, 27 Mar 2013 09:24:28 +0100 [thread overview]
Message-ID: <vpq38vh1c8z.fsf@grenoble-inp.fr> (raw)
In-Reply-To: <20130326202722.GA22769@sigill.intra.peff.net> (Jeff King's message of "Tue, 26 Mar 2013 16:27:22 -0400")
Jeff King <peff@peff.net> writes:
> I probably shouldn't have included this middle patch at all, because
> the interesting thing is what happens when we do turn it off.
Actually, I think the warning is the most important part. With the
warning enabled, people should notice they are doing something
potentially wrong and dangerous, so the warning essentially fixes the
issue in the short term.
I also think that changing the default behavior later makes sense (but I
agree that replacing "in Git 2.0" with "in a future version of Git" is
better, there's no urgency for this change and people start looking
forward 2.0).
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-03-27 8:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 21:38 git ate my home directory :-( Richard Weinberger
2013-03-25 21:43 ` Jonathan Nieder
2013-03-25 22:02 ` Junio C Hamano
2013-03-25 22:08 ` Jonathan Nieder
2013-03-25 22:15 ` Junio C Hamano
2013-03-25 22:06 ` Junio C Hamano
2013-03-25 22:09 ` Richard Weinberger
2013-03-25 22:15 ` Jonathan Nieder
2013-03-25 22:20 ` Junio C Hamano
2013-03-25 22:27 ` Richard Weinberger
2013-03-25 22:13 ` Jonathan Nieder
2013-03-25 22:21 ` Brandon Casey
2013-03-26 8:02 ` Philip Oakley
2013-03-26 9:48 ` Duy Nguyen
2013-03-26 15:04 ` Jeff King
2013-03-26 16:32 ` Junio C Hamano
2013-03-27 13:05 ` Duy Nguyen
2013-03-26 21:47 ` Philip Oakley
2013-03-26 13:07 ` Richard Weinberger
2013-03-26 14:56 ` Jeff King
2013-03-26 17:06 ` Richard Weinberger
2013-03-26 17:20 ` demerphq
2013-03-26 17:48 ` Jeff King
2013-03-26 19:08 ` demerphq
2013-03-26 17:41 ` Jeff King
2013-03-26 18:20 ` Junio C Hamano
2013-03-26 20:08 ` Jeff King
2013-03-26 20:11 ` [DONOTAPPLY PATCH 1/3] environment: set GIT_WORK_TREE when we figure out work tree Jeff King
2013-03-26 20:16 ` Jonathan Nieder
2013-03-26 20:12 ` [DONOTAPPLY PATCH 2/3] setup: warn about implicit worktree with $GIT_DIR Jeff King
2013-03-26 20:21 ` Jonathan Nieder
2013-03-26 20:27 ` Jeff King
2013-03-26 20:35 ` Jonathan Nieder
2013-03-27 8:24 ` Matthieu Moy [this message]
2013-03-26 20:13 ` [DONOTAPPLY PATCH 3/3] setup: treat GIT_DIR without GIT_WORK_TREE as a bare repo Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq38vh1c8z.fsf@grenoble-inp.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).