git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, stolee@gmail.com
Subject: Re: [PATCH v2 2/2] fetch: do not override partial clone filter
Date: Mon, 28 Sep 2020 16:43:09 -0700	[thread overview]
Message-ID: <xmqq1riljwmq.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: c3ced598751ae8fe7b7b6e787474331cf8219802.1601331788.git.jonathantanmy@google.com

Jonathan Tan <jonathantanmy@google.com> writes:

>  test_expect_success 'partial clone with -o' '
>  	partial_clone_server server &&
> -	git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client
> +	git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client &&
> +	test_cmp_config -C client "blob:limit=0" --get-all remote.blah.partialclonefilter
>  '

Makes sense to piggyback on this existing test.  It also makes sense
to ensure that the original one is all and the only filter that is
being configured.

Will queue.  Let's merge them to 'next'.


      reply	other threads:[~2020-09-28 23:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  3:03 [PATCH 0/2] Fix overriding of partial clone filter when lazy-fetching Jonathan Tan
2020-09-22  3:03 ` [PATCH 1/2] promisor-remote: remove unused variable Jonathan Tan
2020-09-22  3:03 ` [PATCH 2/2] fetch: do not override partial clone filter Jonathan Tan
2020-09-22  5:46   ` Junio C Hamano
2020-09-22 11:35     ` Derrick Stolee
2020-09-22 15:51       ` Junio C Hamano
2020-09-22  5:45 ` [PATCH 0/2] Fix overriding of partial clone filter when lazy-fetching Junio C Hamano
2020-09-28 22:26 ` [PATCH v2 " Jonathan Tan
2020-09-28 22:26   ` [PATCH v2 1/2] promisor-remote: remove unused variable Jonathan Tan
2020-09-28 22:26   ` [PATCH v2 2/2] fetch: do not override partial clone filter Jonathan Tan
2020-09-28 23:43     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1riljwmq.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).