From: Junio C Hamano <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: firstname.lastname@example.org, "Eric Sunshine" <email@example.com>, "Martin Ågren" <firstname.lastname@example.org> Subject: Re: [PATCH v2 4/8] shortlog: match commit trailers with --group Date: Mon, 28 Sep 2020 10:01:41 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20200928031752.GA3059492@coredump.intra.peff.net> (Jeff King's message of "Sun, 27 Sep 2020 23:17:52 -0400") Jeff King <firstname.lastname@example.org> writes: > I wondered if this might confuse people reading the series, and almost > called attention to it in the cover letter. Now that you've presumably > read through and figured it out, is it worth going back and amending the > commit message? It's more of a point for reviewers, I think, but perhaps > somebody reading the commits later would care. When I read history older than the immediate past, I usuall start at the point 'git blame' found and then go back---going forward is much less natural operation. If my "git blame" session happens to hit an earlier part of this series, perhaps the future-me would get a wrong impression that originally the feature was in a limited form and was extended later in a separate series? I dunno. I did wish the log message said what was going on while reading, but that is a perfectionist in me speaking, and not a complaint that log messages that did not say the future plans in the series were offense that deserves a rejection. A good summary in "What's cooking" report would become a merge commit log message, and we can teach users to go from 'git blame', find where the entire series was merged to the mainline and then read from there---and it would be sufficient if the summary of the topic described the endgame well.
next prev parent reply other threads:[~2020-09-28 17:01 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-25 7:01 [PATCH 0/8] parsing trailers with shortlog Jeff King 2020-09-25 7:01 ` [PATCH 1/8] shortlog: change "author" variables to "ident" Jeff King 2020-09-25 7:02 ` [PATCH 2/8] shortlog: refactor committer/author grouping Jeff King 2020-09-25 20:05 ` Eric Sunshine 2020-09-27 8:03 ` Jeff King 2020-09-27 8:08 ` Jeff King 2020-09-27 8:23 ` Eric Sunshine 2020-09-26 12:31 ` Martin Ågren 2020-09-27 7:59 ` Jeff King 2020-09-25 7:02 ` [PATCH 3/8] trailer: add interface for iterating over commit trailers Jeff King 2020-09-26 12:39 ` Martin Ågren 2020-09-27 8:20 ` Jeff King 2020-09-25 7:03 ` [PATCH 4/8] shortlog: match commit trailers with --group Jeff King 2020-09-25 7:05 ` [PATCH 5/8] shortlog: de-duplicate trailer values Jeff King 2020-09-25 7:05 ` [PATCH 6/8] shortlog: rename parse_stdin_ident() Jeff King 2020-09-25 7:05 ` [PATCH 7/8] shortlog: parse trailer idents Jeff King 2020-09-25 7:05 ` [PATCH 8/8] shortlog: allow multiple groups to be specified Jeff King 2020-09-25 20:23 ` Eric Sunshine 2020-09-27 8:06 ` Jeff King 2020-09-26 12:48 ` Martin Ågren 2020-09-27 8:25 ` Jeff King 2020-09-25 14:27 ` [PATCH 0/8] parsing trailers with shortlog Derrick Stolee 2020-09-25 16:57 ` Junio C Hamano 2020-09-27 8:39 ` [PATCH v2 " Jeff King 2020-09-27 8:39 ` [PATCH v2 1/8] shortlog: change "author" variables to "ident" Jeff King 2020-09-27 19:18 ` Junio C Hamano 2020-09-27 8:39 ` [PATCH v2 2/8] shortlog: add grouping option Jeff King 2020-09-27 8:40 ` [PATCH v2 3/8] trailer: add interface for iterating over commit trailers Jeff King 2020-09-27 8:40 ` [PATCH v2 4/8] shortlog: match commit trailers with --group Jeff King 2020-09-27 19:51 ` Junio C Hamano 2020-09-28 3:17 ` Jeff King 2020-09-28 17:01 ` Junio C Hamano [this message] 2020-09-27 8:40 ` [PATCH v2 5/8] shortlog: de-duplicate trailer values Jeff King 2020-09-27 20:23 ` Junio C Hamano 2020-09-28 3:19 ` Jeff King 2020-09-27 8:40 ` [PATCH v2 6/8] shortlog: rename parse_stdin_ident() Jeff King 2020-09-27 8:40 ` [PATCH v2 7/8] shortlog: parse trailer idents Jeff King 2020-09-27 20:49 ` Junio C Hamano 2020-09-27 8:40 ` [PATCH v2 8/8] shortlog: allow multiple groups to be specified Jeff King 2020-09-27 21:18 ` Junio C Hamano 2020-09-28 3:25 ` Jeff King 2020-12-28 11:29 ` Junio C Hamano 2021-02-04 6:44 ` Junio C Hamano 2020-09-27 14:38 ` [PATCH v2 0/8] parsing trailers with shortlog Martin Ågren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2 4/8] shortlog: match commit trailers with --group' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).