From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Trygve Aaberge <trygveaa@gmail.com>,
git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>,
Heba Waly <heba.waly@gmail.com>
Subject: Re: [PATCH 1/2] Wait for child on signal death for aliases to builtins
Date: Mon, 06 Jul 2020 18:48:07 -0700 [thread overview]
Message-ID: <xmqq1rlo859k.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2007050410100.50@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Sun, 5 Jul 2020 04:15:56 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Thank you for those references. I did try to make sure that b914084007
> would not regress on anything, but apparently I failed to verify the final
> form. Since all it did was to remove `#if 0`...`#endif` guards, it was
> unfortunately quite easy for this regression to slip in.
Yeah, I recall wondering why it was safe to suddenly enable the
segment of the disabled code all of sudden.
next prev parent reply other threads:[~2020-07-07 1:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 22:18 [PATCH 1/2] Wait for child on signal death for aliases to builtins trygveaa
2020-07-04 22:18 ` [PATCH 2/2] Wait for child on signal death for aliases to externals trygveaa
2020-07-06 21:14 ` Jeff King
2020-07-07 1:38 ` Junio C Hamano
2020-07-07 10:19 ` Trygve Aaberge
2020-07-07 22:06 ` Jeff King
2020-07-05 2:15 ` [PATCH 1/2] Wait for child on signal death for aliases to builtins Johannes Schindelin
2020-07-07 1:48 ` Junio C Hamano [this message]
2020-07-06 20:41 ` Jeff King
2020-07-07 1:50 ` Junio C Hamano
2020-07-07 10:23 ` Trygve Aaberge
2020-07-07 12:17 ` [PATCH v2 " trygveaa
2020-07-07 12:17 ` [PATCH v2 2/2] Wait for child on signal death for aliases to externals trygveaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rlo859k.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=heba.waly@gmail.com \
--cc=jeffhost@microsoft.com \
--cc=trygveaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).