From: Junio C Hamano <gitster@pobox.com>
To: Charles Bailey <cbailey32@bloomberg.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add extra logic required to detect endianness on Solaris
Date: Thu, 01 May 2014 12:22:08 -0700 [thread overview]
Message-ID: <xmqq1twdcnj3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqq61lpcnpd.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 01 May 2014 12:18:22 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Just a thought.
>
> I am wondering if you may want to go the other way around. That is,
> instead of using "we have byte-order, big and little and the way to
> determine endianness is to see byte-order matches which of the
> latter two", use "there may be either big or little but not both
> defined, and that is how you learn the byte-order".
>
> And make these two macros match what Solaris happens to use.
>
> I am not sure which variant I like better myself, though.
> ...
The "how-about-this" patch in the pregvious message forgets the
default case where byte-order, little and big are defined with
leading double underscore, which must also be handled, if we want to
take this aproach.
next prev parent reply other threads:[~2014-05-01 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 7:43 [PATCH] Add extra logic required to detect endianness on Solaris Charles Bailey
2014-05-01 18:58 ` Junio C Hamano
2014-05-01 19:18 ` Junio C Hamano
2014-05-01 19:22 ` Junio C Hamano [this message]
2014-05-02 7:49 ` Charles Bailey
2014-05-02 7:55 ` [PATCH] Detect endianness on more platforms that don't use BYTE_ORDER Charles Bailey
2014-05-02 16:48 ` Junio C Hamano
2014-05-02 16:58 ` Charles Bailey
2014-05-02 19:34 ` Junio C Hamano
2014-05-02 19:43 ` Junio C Hamano
2014-05-02 20:02 ` Charles Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1twdcnj3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=cbailey32@bloomberg.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).