From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] CodingGuidelines: explicitly allow "local" for test scripts
Date: Wed, 05 May 2021 08:55:20 +0900 [thread overview]
Message-ID: <xmqq35v26olz.fsf@gitster.g> (raw)
In-Reply-To: <YJHWJRYOcFEvHoD/@camp.crustytoothpaste.net> (brian m. carlson's message of "Tue, 4 May 2021 23:17:57 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> One of the main reasons the Austin Group is having trouble standardizing
> it is because some shells implement it with lexical scoping and some use
> dynamic scoping, but if we try not to make too many assumptions, we'll
> probably be okay.
Thanks for raising that one. As long as we make sure that our
script would work with anybody's "local", I do not care very much.
I just didn't think we want to spend the effort to explain that in
the documentation and enforce it---compared to the effort, just
saying "no" is certainly easier.
But if somebody wants an incremental patch on top to spell out how
"local" is allowed to be used in our scripts, that's fine by me.
next prev parent reply other threads:[~2021-05-04 23:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 4:10 [PATCH] CodingGuidelines: explicitly allow "local" for test scripts Junio C Hamano
2021-05-03 4:21 ` Eric Sunshine
2021-05-03 5:21 ` Junio C Hamano
2021-05-03 5:23 ` [PATCH v2] " Junio C Hamano
2021-05-03 9:01 ` Ævar Arnfjörð Bjarmason
2021-05-04 3:01 ` Junio C Hamano
2021-05-04 12:27 ` Ævar Arnfjörð Bjarmason
2021-05-04 12:50 ` Junio C Hamano
2021-05-04 15:09 ` Ævar Arnfjörð Bjarmason
2021-05-04 20:22 ` Felipe Contreras
2021-05-04 23:17 ` brian m. carlson
2021-05-04 23:55 ` Junio C Hamano [this message]
2021-05-05 0:08 ` Felipe Contreras
2021-05-05 1:58 ` brian m. carlson
2021-05-05 3:59 ` Felipe Contreras
2021-05-05 14:16 ` Jeff King
2021-05-05 17:18 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35v26olz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).