From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: shubham verma <shubhunic@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2 00/10] Modernizing the t7001 test script
Date: Wed, 10 Feb 2021 23:37:03 -0800 [thread overview]
Message-ID: <xmqq35y3ys0w.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cSXi7Ct48gqkBVvBtOm6bMqDhPcxXeiK3ZytAitZXNT5Q@mail.gmail.com> (Eric Sunshine's message of "Thu, 11 Feb 2021 02:28:54 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Tue, Feb 9, 2021 at 6:13 PM Junio C Hamano <gitster@pobox.com> wrote:
>> shubham verma <shubhunic@gmail.com> writes:
>> > In this patch series modernize the t7001 test script by changing the
>> > style of its tests from an old one to the modern one and by cleaning
>> > up the test script.
>> >
>> I would have used test_write_lines instead of here-doc in 9/10, but
>> that is such a minor preference thing that it is not worth going
>> back and replace. Nothing else stood out during my cursory scan.
>
> I read over the entire series and likewise didn't find anything to
> comment on, thus consider it in good shape. For what it's worth,
> consider this series:
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Yup, this one looked good to me. Thanks.
Except that the author's name were spelled in all lowercase, unlike
v1, which made me wonder if it was intentional, that is.
next prev parent reply other threads:[~2021-02-11 7:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 17:32 [PATCH v2 00/10] Modernizing the t7001 test script shubham verma
2021-02-09 17:32 ` [PATCH v2 01/10] t7001: modernize test formatting shubham verma
2021-02-09 17:32 ` [PATCH v2 02/10] t7001: indent with TABs instead of spaces shubham verma
2021-02-09 17:32 ` [PATCH v2 03/10] t7001: remove unnecessary blank lines shubham verma
2021-02-09 17:32 ` [PATCH v2 04/10] t7001: modernize subshell formatting shubham verma
2021-02-09 17:32 ` [PATCH v2 05/10] t7001: remove whitespace after redirect operators shubham verma
2021-02-09 17:32 ` [PATCH v2 06/10] t7001: avoid using `cd` outside of subshells shubham verma
2021-02-09 17:32 ` [PATCH v2 07/10] t7001: use '>' rather than 'touch' shubham verma
2021-02-09 17:32 ` [PATCH v2 08/10] t7001: put each command on a separate line shubham verma
2021-02-09 17:32 ` [PATCH v2 09/10] t7001: use here-docs instead of echo shubham verma
2021-02-09 17:32 ` [PATCH v2 10/10] t7001: use `test` rather than `[` shubham verma
2021-02-09 19:24 ` [PATCH v2 00/10] Modernizing the t7001 test script Eric Sunshine
2021-02-09 22:58 ` Junio C Hamano
2021-02-11 7:28 ` Eric Sunshine
2021-02-11 7:37 ` Junio C Hamano [this message]
2021-02-11 7:56 ` Shubham Verma
2021-02-11 7:59 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq35y3ys0w.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=shubhunic@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).