git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "John Lin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, John Lin <johnlinp@gmail.com>
Subject: Re: [PATCH] bash-completion: add git-prune into bash completion
Date: Mon, 22 Jun 2020 11:28:53 -0700	[thread overview]
Message-ID: <xmqq366ndkey.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.667.git.1592784835441.gitgitgadget@gmail.com> (John Lin via GitGitGadget's message of "Mon, 22 Jun 2020 00:13:55 +0000")

"John Lin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: John Lin <johnlinp@gmail.com>
>
> Sometimes git would suggest the user to run `git prune` when there are
> too many unreachable loose objects. It's more user-friendly if we add
> git-prune into bash completion.

Yes, but it does not suggest all the time, and there is a reason.
Most of the time "gc" is more appropriate, but there are narrow
cases where "prune" is more appropriate and that is when the users
will see suggestion to run "prune".

Isn't it too much to type p-r-u-n-e while seeing that message,
typing as you read it?

I do not think it hurts to complete "git prune", in the sense that
we would want to avoid completing potentially destructive operation
to those who do not understand the implications, because the command
is pretty much benign.  But I am not sure it forces users to type
too many keystrokes too frequently that it requires a tab
completion.  I dunno.

Will queue for now.

Thanks.

  reply	other threads:[~2020-06-22 18:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22  0:13 [PATCH] bash-completion: add git-prune into bash completion John Lin via GitGitGadget
2020-06-22 18:28 ` Junio C Hamano [this message]
2020-07-10  1:18   ` 林自均
2020-07-10 23:08     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq366ndkey.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johnlinp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).