From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, stolee@gmail.com,
Garima Singh <garima.singh@microsoft.com>
Subject: Re: [PATCH v2 0/2] Restrict when prefetcing occurs
Date: Thu, 02 Apr 2020 13:28:53 -0700 [thread overview]
Message-ID: <xmqq369l3a4a.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <cover.1585854639.git.jonathantanmy@google.com> (Jonathan Tan's message of "Thu, 2 Apr 2020 12:19:15 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
> Thanks, everyone, for your review.
>
> New in v2:
> - added restriction on fetching rename_src's blob, following Stolee's
> comment
> - folded oid_nr==0 check into promisor_remote_get_direct(), following
> Stolee's comment
> - used "mv server/b server/c", following Stolee's comment
> - made diff_add_if_missing() public function, following Junio's comment
>
> I didn't change the "continue" part that Stolee suggested [1].
>
> [1] https://lore.kernel.org/git/xmqqlfng75cl.fsf@gitster.c.googlers.com/
>
> Jonathan Tan (2):
> promisor-remote: accept 0 as oid_nr in function
> diff: restrict when prefetching occurs
>
> builtin/index-pack.c | 5 ++--
> diff.c | 49 +++++++++++++++++++++++------------
> diffcore-rename.c | 37 +++++++++++++++++++++++++-
> diffcore.h | 10 ++++++-
> promisor-remote.c | 3 +++
> promisor-remote.h | 8 ++++++
> t/t4067-diff-partial-clone.sh | 48 ++++++++++++++++++++++++++++++++++
> unpack-trees.c | 5 ++--
> 8 files changed, 141 insertions(+), 24 deletions(-)
I notice that a439b4ef (diff: skip batch object download when
possible, 2020-03-30) by Garima seems to aim for something similar.
I'll for now keep both topics with conflict resolution, but it may
make sense for you two to compare notes.
I especially like the way this series enumerates the formats that
matter to prefetching and the way the change is localized in
diffcore_std(); the other topic splits a similar logic (with
different criteria) between diff_setup_done() and diffcore_std(),
which I found suboptimal.
Thanks.
next prev parent reply other threads:[~2020-04-02 20:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 2:04 [PATCH] diff: restrict when prefetching occurs Jonathan Tan
2020-03-31 12:14 ` Derrick Stolee
2020-03-31 16:50 ` Jonathan Tan
2020-03-31 17:48 ` Derrick Stolee
2020-03-31 18:21 ` Junio C Hamano
2020-03-31 18:15 ` Junio C Hamano
2020-04-02 19:19 ` [PATCH v2 0/2] Restrict when prefetcing occurs Jonathan Tan
2020-04-02 19:19 ` [PATCH v2 1/2] promisor-remote: accept 0 as oid_nr in function Jonathan Tan
2020-04-02 19:46 ` Junio C Hamano
2020-04-02 23:01 ` Jonathan Tan
2020-04-02 19:19 ` [PATCH v2 2/2] diff: restrict when prefetching occurs Jonathan Tan
2020-04-02 20:08 ` Junio C Hamano
2020-04-02 23:09 ` Jonathan Tan
2020-04-02 23:25 ` Junio C Hamano
2020-04-02 23:54 ` Junio C Hamano
2020-04-03 21:35 ` Jonathan Tan
2020-04-03 22:12 ` Junio C Hamano
2020-04-02 20:28 ` Junio C Hamano [this message]
2020-04-06 11:44 ` [PATCH v2 0/2] Restrict when prefetcing occurs Derrick Stolee
2020-04-06 11:57 ` Garima Singh
2020-04-07 22:11 ` [PATCH v3 0/4] " Jonathan Tan
2020-04-07 22:11 ` [PATCH v3 1/4] promisor-remote: accept 0 as oid_nr in function Jonathan Tan
2020-04-07 22:11 ` [PATCH v3 2/4] diff: make diff_populate_filespec_options struct Jonathan Tan
2020-04-07 23:44 ` Junio C Hamano
2020-04-07 22:11 ` [PATCH v3 3/4] diff: refactor object read Jonathan Tan
2020-04-07 22:11 ` [PATCH v3 4/4] diff: restrict when prefetching occurs Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq369l3a4a.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=garima.singh@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).