git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Son Luong Ngoc <son.luong@booking.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Thomas Gummerer <t.gummerer@gmail.com>,
	Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
Subject: Re: Git Rebase: test failing with GIT_TEST_STASH_USE_BUILTIN=false
Date: Tue, 25 Feb 2020 08:57:37 -0800	[thread overview]
Message-ID: <xmqq36ayob9a.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <61922A39-13DC-4B17-94FC-7F67DF308347@booking.com> (Son Luong Ngoc's message of "Mon, 24 Feb 2020 09:33:31 +0100")

Son Luong Ngoc <son.luong@booking.com> writes:

> I have been trying to build git from source and noticing that some
> tests have been failing since 2.25 with the flag
> "GIT_TEST_STASH_USE_BUILTIN=false"
>
> I think in 2.25 t3903.103 started to fail (rebase related) and
> current master t3904 may be failing also.
>
> Is "GIT_TEST_STASH_USE_BUILTIN=false" is still being tested with
> or are we totally deprecating this flag?

In the longer term, when "git stash" gains new features that did not
exist in the original scripted version, tests that observe how these
features work would start failing when using the scripted version.

I picked some people from "git shortlog --no-merges builtin/stash.c"
and placed them on the CC line---perhaps they may know more.  It
happens that Johannes is also familiar with "rebase", which you
said is involved in the test failure, so I'd imagine he would be the
best person to ask.

Thanks for a report.



  reply	other threads:[~2020-02-25 16:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24  8:33 Son Luong Ngoc
2020-02-25 16:57 ` Junio C Hamano [this message]
     [not found]   ` <710DB9BA-D134-48E7-8CAB-B8816FED8AB8@booking.com>
2020-03-01  9:59     ` [External] " Son Luong Ngoc
2020-03-01 10:40       ` Son Luong Ngoc
2020-03-02 18:18   ` [PATCH 1/2] stash: get git_stash_config at the top level Thomas Gummerer
2020-03-02 18:19     ` [PATCH 2/2] stash: remove the stash.useBuiltin setting Thomas Gummerer
2020-03-02 21:30       ` Junio C Hamano
2020-03-02 22:21       ` non-regression bug in 'git merge' (really, xdiff/xmerge, I think) Junio C Hamano
2020-03-06 15:48         ` Elijah Newren
2020-03-03 13:33       ` [PATCH 2/2] stash: remove the stash.useBuiltin setting Johannes Schindelin
2020-03-03 16:47         ` Junio C Hamano
2020-03-03 17:36         ` Thomas Gummerer
2020-03-04 16:41           ` Johannes Schindelin
     [not found]       ` <CA+P7+xqVyMnG6FiyL4hngPfEEMi5CKz1qN5Cy1TMMpLg3CmsBw@mail.gmail.com>
2020-03-06 14:11         ` Johannes Schindelin
2020-03-06 17:29         ` Thomas Gummerer
2020-03-03 17:46     ` [PATCH v2 1/2] stash: get git_stash_config at the top level Thomas Gummerer
2020-03-03 17:46       ` [PATCH v2 2/2] stash: remove the stash.useBuiltin setting Thomas Gummerer
2020-03-03 18:45         ` Junio C Hamano
2020-03-04 11:49           ` Thomas Gummerer
2020-03-04 16:25             ` Junio C Hamano
2020-03-05 17:04               ` Thomas Gummerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq36ayob9a.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=son.luong@booking.com \
    --cc=t.gummerer@gmail.com \
    --cc=ungureanupaulsebastian@gmail.com \
    --subject='Re: Git Rebase: test failing with GIT_TEST_STASH_USE_BUILTIN=false' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).