Re: [PATCH] status: teach "status --short" to respect "--show-stash"

[Junio C Hamano <gitster@pobox.com>]

"Eric N. Vander Weele" <ericvw@gmail.com> writes:

> Enable printing the entries currently stashed away in the short format.
> This prints the stash information after the path status to be symmetric
> with "status --long --show-stash".
>
> Signed-off-by: Eric N. Vander Weele <ericvw@gmail.com>
> ---
>  Documentation/git-status.txt |  4 ++++
>  wt-status.c                  | 17 +++++++++++++++++
>  2 files changed, 21 insertions(+)
>
> diff --git a/Documentation/git-status.txt b/Documentation/git-status.txt
> index 7731b45f07..c1afc3282c 100644
> --- a/Documentation/git-status.txt
> +++ b/Documentation/git-status.txt
> @@ -244,6 +244,10 @@ If -b is used the short-format status is preceded by a line
>  
>      ## branchname tracking info
>  
> +If --show-stash is used the short-format status is followed by a line
> +
> +    ## stash: <n> (entry|entries)
> +

Hmmmm.  Would readers misinterpret we are talking about a branch
whose name is stash something?  I am not suggesting to change ##
introducer to some random letters, which would break scripts even
worse.

Doesn't the Porcelain Format v1 call the same codepath as
shortstatus?  We promise that its output never changes to support
existing scripts, but now they will start seeing "## stash:" that
they do not understand and barf?

Isn't this information available to scripts that want to read from
porcelain v2 output format (which is meant to be extensible by
allowing easy-to-parse optional headers, which this stash thing
exactly is).

Thanks.