From: Junio C Hamano <gitster@pobox.com>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v2 0/2] completion: improvements for git stash
Date: Fri, 20 Apr 2018 10:38:19 +0900 [thread overview]
Message-ID: <xmqq36zqd5dg.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180419232514.16572-1-t.gummerer@gmail.com> (Thomas Gummerer's message of "Fri, 20 Apr 2018 00:25:12 +0100")
Thomas Gummerer <t.gummerer@gmail.com> writes:
> I didn't find a good way to implement "reluctant completion" (I'm also
> by no means an expert in bash completion, so there may well be a way I
> couldn't find by googl'ing around), so I left that out of this
> series.
>
> I don't think it's strictly necessary for the deprecation either, as
> we can just print a warning message when the user actually uses 'git
> stash save' at some point, which would make a message printed when
> using the completion redundant anyway. I feel like that warning
> message is not something we're quite ready for yet and I'd rather wait
> a few more releases before doing that though.
Yeah, I agree that what you outined above is quite sensible.
Thanks, will queue.
prev parent reply other threads:[~2018-04-20 1:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 21:29 [PATCH 0/3] completion: improvements for git stash Thomas Gummerer
2018-04-17 21:29 ` [PATCH 1/3] completion: rename save_opts to default_opts for stash Thomas Gummerer
2018-04-17 21:29 ` [PATCH 2/3] completion: stop completing 'save' as stash subcommand Thomas Gummerer
2018-04-17 21:29 ` [PATCH 3/3] completion: make stash -p and alias for stash push -p Thomas Gummerer
2018-04-18 8:32 ` [PATCH 0/3] completion: improvements for git stash Junio C Hamano
2018-04-18 21:15 ` Thomas Gummerer
2018-04-19 23:25 ` [PATCH v2 0/2] " Thomas Gummerer
2018-04-19 23:25 ` [PATCH v2 1/2] completion: stop showing 'save' for stash by default Thomas Gummerer
2018-04-20 5:17 ` Duy Nguyen
2018-04-22 20:36 ` Thomas Gummerer
2018-04-19 23:25 ` [PATCH v2 2/2] completion: make stash -p and alias for stash push -p Thomas Gummerer
2018-04-20 1:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36zqd5dg.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).