From: Junio C Hamano <gitster@pobox.com>
To: "Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, derrickstolee@github.com,
Johannes.Schindelin@gmx.de, steadmon@google.com,
chooglen@google.com, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2] Documentation: add ReviewingGuidelines
Date: Mon, 19 Sep 2022 14:37:33 -0700 [thread overview]
Message-ID: <xmqq4jx39hb6.fsf@gitster.g> (raw)
In-Reply-To: <pull.1348.v2.git.1663614767058.gitgitgadget@gmail.com> (Victoria Dye via GitGitGadget's message of "Mon, 19 Sep 2022 19:12:46 +0000")
"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Victoria Dye <vdye@github.com>
>
> Add a reviewing guidelines document including advice and common terminology
> used in Git mailing list reviews. The document is included in the
> 'TECH_DOCS' list in order to include it in Git's published documentation.
>
> Helped-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Helped-by: Derrick Stolee <derrickstolee@github.com>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Helped-by: Josh Steadmon <steadmon@google.com>
> Signed-off-by: Victoria Dye <vdye@github.com>
> ---
> Documentation: add ReviewingGuidelines
>
> This patch follows up on a discussion a few weeks ago in the Git IRC
> standup [1], where it was mentioned that it would be nice to have
> consistent definitions for common review terminology (like 'nit:'). The
> "ReviewingGuidelines" document created here builds on that idea, as well
> as past discussions around the idea of advice for reviewers (similar to
> the guidelines for new contributors in MyFirstContribution [2]).
Thanks. Will queue.
I think this is ready for 'next' and then to 'master' during this
cycle. Thanks for writing it, and thanks all for reviewing it.
next prev parent reply other threads:[~2022-09-19 21:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 18:13 [PATCH] Documentation: add ReviewingGuidelines Victoria Dye via GitGitGadget
2022-09-09 19:42 ` Junio C Hamano
2022-09-13 17:54 ` Junio C Hamano
2022-09-13 23:11 ` Victoria Dye
2022-09-19 15:08 ` Derrick Stolee
2022-09-19 15:48 ` Johannes Schindelin
2022-09-15 23:25 ` Josh Steadmon
2022-09-19 18:17 ` Glen Choo
2022-09-19 19:12 ` [PATCH v2] " Victoria Dye via GitGitGadget
2022-09-19 20:15 ` Josh Steadmon
2022-09-19 21:37 ` Junio C Hamano [this message]
2022-09-20 0:43 ` Elijah Newren
2022-09-20 21:23 ` Konstantin Ryabitsev
2022-09-22 4:24 ` Shaoxuan Yuan
2022-09-22 13:29 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jx39hb6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chooglen@google.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=steadmon@google.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).