git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Robert Estelle <robertestelle@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] color: support "default" to restore fg/bg color
Date: Thu, 28 Oct 2021 09:41:51 -0700	[thread overview]
Message-ID: <xmqq4k91t834.fsf@gitster.g> (raw)
In-Reply-To: <CAMmwyQor1AekB9cCUE3osLJeb2r_w0q0T1JqUcNFk6L=7O2-Jg@mail.gmail.com> (Robert Estelle's message of "Mon, 25 Oct 2021 17:54:50 -0700")

Robert Estelle <robertestelle@gmail.com> writes:

> Those are good examples. Note that this applies to more cases than
> those relying on transparency or patterns: color terms often have
> defaults that are not identical to their ANSI palette. I suspect
> *most* themes are probably this way, based on a quick sampling.
>
> You can see a bunch of examples here:
> https://github.com/mbadolato/iTerm2-Color-Schemes#screenshots in all
> the themes where the background color in the "40m" column isn't the
> same as the unset column before it. (All of Terminal.app's built-in
> themes are that way; I know xterm defaults to black on white vs white
> on black; and so on).

I think you are wasting your time giving these to _us_ on the list
who happen to already understand what the issue you are attempting
to fix with these patches.  The suggestion was that you would help
future readers of "git log" if you wrote even just one or a few of
them in your proposed log message.  Those who will be digging the
history, perhaps they want to fix something in near-by code, may not
be aware of this discussion but the log message is a good place to
leave a note for them.

Thanks.


  reply	other threads:[~2021-10-28 16:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 22:32 [PATCH 0/2] color: support "default" to restore fg/bg color Robert Estelle via GitGitGadget
2021-10-25 22:32 ` [PATCH 1/2] color: add missing GIT_COLOR_* white/black constants Robert Estelle via GitGitGadget
2021-10-25 22:32 ` [PATCH 2/2] color: support "default" to restore fg/bg color Robert Estelle via GitGitGadget
2021-10-25 22:39   ` brian m. carlson
2021-10-25 22:49     ` Junio C Hamano
2021-10-26  0:54       ` Robert Estelle
2021-10-28 16:41         ` Junio C Hamano [this message]
2021-10-28 17:33           ` Robert Estelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4k91t834.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=robertestelle@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).