git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Yuri <yuri@rawbw.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Git re-creates newly added directory when it is pushed
Date: Mon, 30 Aug 2021 21:41:12 -0700	[thread overview]
Message-ID: <xmqq4kb6z0nr.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BFE_LB=MYcJ80g=6OjvcXh-SjR_9_ynVdX5i9ruGBqh2Q@mail.gmail.com> (Elijah Newren's message of "Mon, 30 Aug 2021 19:15:58 -0700")

Elijah Newren <newren@gmail.com> writes:

>> This is one of the reasons why "rebase" (especially "rebase -i") may
>> want to insist starting at the top-level of the working tree, like
>> "git bisect" does.  Because running the command from a subdirectory
>> works most of the time until it doesn't, people tend to complain why
>> they should go up to the top-level before they can run the command.
>>
>> And this is why---it causes end-user confusion.
>
> Makes sense to me; I'll submit a patch.

Well, but not too hastily.

It is one thing to be firm and resist those who want to loosen "git
bisect" to allow it to start in a subdirectory, in order to keep
protecting the innocent who are already protected with the current
safeguard from confusion.

It is entirely a different thing to tighten "git rebase"
retroactively to break those who are used to see the command start
in a subdirectory.

The potential confusion that is caused may be the same between
commands, but either change can potentially hurt existing users.

I hope your patch would serve as a good discussion starter.  We may
end up loosening "git bisect" to expose our users to possible
confusion, the same one that already exists for users of "git
rebase", in the name of consistency, and it might even turn out to
be a good change.  Or not.

In any case, it would be a good opportunity to force people
thoroughly think things through.

Thanks.

      reply	other threads:[~2021-08-31  4:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28  3:46 Git re-creates newly added directory when it is pushed Yuri
2021-08-28  5:33 ` Elijah Newren
2021-08-28  5:43   ` Yuri
2021-08-30  0:07   ` Junio C Hamano
2021-08-30  0:14     ` Yuri
2021-08-30  0:29       ` Junio C Hamano
2021-08-30  9:27         ` Philip Oakley
2021-08-31  2:15     ` Elijah Newren
2021-08-31  4:41       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq4kb6z0nr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=yuri@rawbw.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).