From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CECDCC4338F for ; Thu, 29 Jul 2021 20:48:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8C13601FC for ; Thu, 29 Jul 2021 20:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbhG2UsM (ORCPT ); Thu, 29 Jul 2021 16:48:12 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:51535 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbhG2UsL (ORCPT ); Thu, 29 Jul 2021 16:48:11 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 71365148515; Thu, 29 Jul 2021 16:48:08 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=UpsPdU4kqJzRpqh0x33CxPa+rQ/0lexbwqdpgH MxxfY=; b=YoDBaKbUIsFWehGC7dzWEo81wkOZMjI3pIWcO391ma81TZViZDL9QK g/gLm5yZePEvUZjz0O0Kb1cEdFU6UiBt8bczljmqS06XxgOuYJdLVwlsraF3JsYF YwfWVIvJ6wlbRU4zyu/QUAdotgBnIwEm1qlE+xyWu02X8+Emdti8Q= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 69C02148514; Thu, 29 Jul 2021 16:48:08 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.71.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id AC654148513; Thu, 29 Jul 2021 16:48:05 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: Elijah Newren via GitGitGadget , git@vger.kernel.org, Eric Sunshine , Elijah Newren , Derrick Stolee Subject: Re: [PATCH v2 0/7] Final optimization batch (#15): use memory pools References: Date: Thu, 29 Jul 2021 13:48:04 -0700 In-Reply-To: (Junio C. Hamano's message of "Thu, 29 Jul 2021 12:46:47 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 462C890E-F0AE-11EB-B489-FA9E2DDBB1FC-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Jeff King writes: > >> On Thu, Jul 29, 2021 at 12:20:13PM -0400, Jeff King wrote: >> >>> I assume your tests are just done using the regular glibc allocator. I >>> also wondered how plugging in a better allocator might fare. Here are >>> timings I did of your mega-renames case with three binaries: one built >>> with USE_MEMORY_POOL set to 0, one with it set to 1, and one with it set >>> to 0 but adding "-ltcmalloc" to EXTLIBS via config.mak. >> >> Oh, btw, I wasn't able to apply your series from the list on top of >> en/ort-perf-batch-14 (there are some problems in patch 4, and "am -3" >> says my clone of git.git is missing some of the pre-image sha1s). I >> fetched ort-perf-batch-15 from https://github.com/newren/git and timed >> that, which I imagine is the same. But you may need to tweak the patches >> so that Junio can pick them up. > > Thanks, but the batch #15 has been in 'seen' since 23rd ;-) Oh, that is the previous round. I haven't had the chance to pick up this new round.