From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: mention Python 3.x supports
Date: Mon, 14 Dec 2020 15:00:00 -0800 [thread overview]
Message-ID: <xmqq4kkoat8v.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201210143017.24615-1-congdanhqx@gmail.com> (=?utf-8?B?IsSQ?= =?utf-8?B?b8OgbiBUcuG6p24gQ8O0bmc=?= Danh"'s message of "Thu, 10 Dec 2020 21:30:17 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> Commit 0b4396f068, (git-p4: make python2.7 the oldest supported version,
> 2019-12-13) pointed out that git-p4 uses Python 2.7-or-later features
> in the code.
>
> In addition, git-p4 gained enough support for Python 3 from
> 6cec21a82f, (git-p4: encode/decode communication with p4 for
> python3, 2019-12-13).
I am not a Perforce user, so with that in mind, please help me make
sure I understand the situation well. The statement "not 3.x, which
is not supported by Perforce" is from early 2013, and 6cec21a82f
talks about the format of marshalled dict object that comes out of
p4 (Perforce) tool that needs to be read in a certain way to be
compatible with Python3. Does that mean sometime in these 6 years,
Perforce started supporting 3.x?
The change to INSTALL just drops the mention of 3.x; do we want to
specifically say that any version of 3.x is OK, or is it generally
accepted that Python 3.x is "later" than "Python 2.7"?
> Let's update our documentation to reflect that fact.
Thanks.
> diff --git a/INSTALL b/INSTALL
> index 9ba33e6a14..8474ad01bf 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -165,8 +165,7 @@ Issues of note:
> use English. Under autoconf the configure script will do this
> automatically if it can't find libintl on the system.
>
> - - Python version 2.4 or later (but not 3.x, which is not
> - supported by Perforce) is needed to use the git-p4 interface
> + - Python version 2.7 or later is needed to use the git-p4 interface
> to Perforce.
next prev parent reply other threads:[~2020-12-14 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 14:30 [PATCH] doc: mention Python 3.x supports Đoàn Trần Công Danh
2020-12-14 23:00 ` Junio C Hamano [this message]
2020-12-15 17:38 ` Đoàn Trần Công Danh
2020-12-15 17:54 ` Yang Zhao
2020-12-15 21:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4kkoat8v.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).