git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stuart MacDonald <stuartm.coding@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [Bug report] includeIf config is not displayed in normal directories
Date: Wed, 16 Dec 2020 15:24:28 -0800	[thread overview]
Message-ID: <xmqq5z512v2r.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPQE4+rhWT9kgusNXOw5cnJ-oFq++4G1FMaXvQ3wppQ0GE0hSA@mail.gmail.com> (Stuart MacDonald's message of "Wed, 16 Dec 2020 15:43:31 -0500")

Stuart MacDonald <stuartm.coding@gmail.com> writes:

> My old understanding of git clone:
> - create sub-directory
> - create subdir/.git and whatever initial states are needed
> - clone the repo from origin into the directory
> - all never having left $CWD
>
> It's actually:
> - create sub-directory
> - cd subdir
> - create ./.git and initial states
> - clone the repo _while inside_ a gitdir
> - cd ..

I am not sure how the above two should make any difference with the
[includeif "gitdir:<pattern>"] matching.  Regardless of where your
$CWD is, the inclusion is decided on the location of the .git/
directory we are dealing with, so as long as "subdir/.git" matches
the pattern given to "gitdir:<pattern>" the inclusion should work
the same way even if the internal implementation of "git clone"
changes between the above two.

IIRC "includeif" is a Peff's brainchild, so I'd ask him to correct
any mistakes in the above paragraph, but I am a bit puzzled as to
what the true misunderstanding is, where the misunderstanding came
from, and which documentation if any we should look into improving.

Thanks.


  reply	other threads:[~2020-12-16 23:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 15:52 [Bug report] includeIf config is not displayed in normal directories Stuart MacDonald
2017-05-11 18:53 ` Possible bug in includeIf / conditional includes on non git initialised directories Raphael Stolt
2017-05-11 20:31   ` Sebastian Schuberth
2017-05-11 23:43     ` Jeff King
2017-05-12  8:58   ` Ævar Arnfjörð Bjarmason
2020-12-15 23:03     ` [Bug report] includeIf config is not displayed in normal directories Ævar Arnfjörð Bjarmason
2020-12-16  0:23       ` Junio C Hamano
2020-12-15 22:23 ` Junio C Hamano
2020-12-16 19:24   ` Jeff King
2020-12-16 20:43     ` Stuart MacDonald
2020-12-16 23:24       ` Junio C Hamano [this message]
2020-12-18  6:23         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5z512v2r.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=stuartm.coding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).