From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZKiS=2H=vger.kernel.org=git-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id EF915C43603
	for <git@archiver.kernel.org>; Tue, 17 Dec 2019 18:16:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id C09D421582
	for <git@archiver.kernel.org>; Tue, 17 Dec 2019 18:16:32 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="HqFBWjuX"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727902AbfLQSQb (ORCPT <rfc822;git@archiver.kernel.org>);
        Tue, 17 Dec 2019 13:16:31 -0500
Received: from pb-smtp20.pobox.com ([173.228.157.52]:51591 "EHLO
        pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727726AbfLQSQb (ORCPT <rfc822;git@vger.kernel.org>);
        Tue, 17 Dec 2019 13:16:31 -0500
Received: from pb-smtp20.pobox.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id 6D1EE9EC4A;
        Tue, 17 Dec 2019 13:16:29 -0500 (EST)
        (envelope-from junio@pobox.com)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=2HrqF6GXPilH1qrjouZ65Vi7nmg=; b=HqFBWj
        uXV9BQERisY9Z2HBN0XLihTnQTLETX4lmYg+tpeQ5GtEpRwCoJGZQ2F4SEv/Xqwt
        N7dh56s9BDAadTF/QKAeKR1BOGavSSDXmmMw4MiP51ZptNb86TmzbVbsI8ABtNJT
        vprwcTxLacFn4Y1mYJYeQEMUQbPG36OIoH92I=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=vSGu3LOeC14fnJ1eEqzOE7rCpCOzo0dU
        hg44gSntHMhPdZ0bzFy09SekV2kCY+yVRv6brb+0FOb6AUOyXra38O/IrNZsLD1Q
        MdD8ED1tfi6mPLYIVhxnNqF1R0FUy0taDs4wAC6WMqCpyvuNWTaiJ1M0qAoJWbEv
        ZUKoTtdHRNQ=
Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1])
        by pb-smtp20.pobox.com (Postfix) with ESMTP id 64CF49EC49;
        Tue, 17 Dec 2019 13:16:29 -0500 (EST)
        (envelope-from junio@pobox.com)
Received: from pobox.com (unknown [34.76.80.147])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 9E2FB9EC46;
        Tue, 17 Dec 2019 13:16:26 -0500 (EST)
        (envelope-from junio@pobox.com)
From:   Junio C Hamano <gitster@pobox.com>
To:     Derrick Stolee <stolee@gmail.com>
Cc:     Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>,
        git@vger.kernel.org, Thomas Rast <tr@thomasrast.ch>,
        Matthieu Moy <Matthieu.Moy@imag.fr>,
        Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH 2/2] Documentation/git-log: mention that line-log regex must match in starting revision
References: <pull.494.git.1576559263.gitgitgadget@gmail.com>
        <4ea4eeae0c1e23221012855168bf6640be93fd4f.1576559263.git.gitgitgadget@gmail.com>
        <1d033204-80fd-25f8-3a80-0cb641953139@gmail.com>
Date:   Tue, 17 Dec 2019 10:16:24 -0800
In-Reply-To: <1d033204-80fd-25f8-3a80-0cb641953139@gmail.com> (Derrick
        Stolee's message of "Tue, 17 Dec 2019 10:34:43 -0500")
Message-ID: <xmqq5zieizrb.fsf@gitster-ct.c.googlers.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 56FD8C5A-20F9-11EA-AB95-B0405B776F7B-77302942!pb-smtp20.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

Derrick Stolee <stolee@gmail.com> writes:

> On 12/17/2019 12:07 AM, Philippe Blain via GitGitGadget wrote:
>> From: Philippe Blain <levraiphilippeblain@gmail.com>
>> 
>> When giving a regex as parameter <start> or <end> in
>> `git log -L <start>,<end>:<file>`, or a function name in
>> `git log -L :<funcname>:<file>`, the given regex must match in the starting
>> revision, or else the command exits with a fatal error.
>> 
>> This is not obvious in the documentation, so add a note to that
>> effect.
>
> This seems helpful. Thanks.

Even when you specify <start> or <end> as a line number, they must
exist in the starting revision or it would be a fatal error.  If we
are clarifying with this patch for completeness, I think we should
also mention it together.  

Or we could even drop the mention of regex and say <start> and
<end>, regardless of how they are specified (including :<funcname>
format), must exist in the starting revision.