From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] t5410: use longer path for sample script
Date: Thu, 25 Oct 2018 10:15:07 +0900 [thread overview]
Message-ID: <xmqq5zxqn7xg.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1810241051440.4546@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 24 Oct 2018 10:53:31 +0200 (DST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Wed, 24 Oct 2018, Jeff King wrote:
>
>> t5410 creates a sample script "alternate-refs", and sets
>> core.alternateRefsCommand to just "alternate-refs". That
>> shouldn't work, as "." is not in our $PATH, and so we should
>> not find it.
>>
>> However, due to a bug in run-command.c, we sometimes find it
>> anyway! Even more confusing, this bug is only in the
>> fork-based version of run-command. So the test passes on
>> Linux (etc), but fails on Windows.
>>
>> In preparation for fixing the run-command bug, let's use a
>> more complete path here.
>>
>> Reported-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
>> Signed-off-by: Jeff King <peff@peff.net>
>> ---
>
> Thank you for the fix! I can confirm that the patch works, and the commit
> message is stellar, as per usual for your contributions.
>
> BTW since this breaks every single one of our Continuous Builds on
> Windows, I would be very much in favor of fast-tracking this to `master`.
>
> Thanks,
> Dscho
I should note to the public that this one, and the companion patch
2/2, owe greatly to you and Peff's efforts.
Thanks, both.
>
>> t/t5410-receive-pack-alternates.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t5410-receive-pack-alternates.sh b/t/t5410-receive-pack-alternates.sh
>> index 457c20c2a5..f00d0da860 100755
>> --- a/t/t5410-receive-pack-alternates.sh
>> +++ b/t/t5410-receive-pack-alternates.sh
>> @@ -23,7 +23,7 @@ test_expect_success 'with core.alternateRefsCommand' '
>> --format="%(objectname)" \
>> refs/heads/public/
>> EOF
>> - test_config -C fork core.alternateRefsCommand alternate-refs &&
>> + test_config -C fork core.alternateRefsCommand ./alternate-refs &&
>> git rev-parse public/branch >expect &&
>> printf "0000" | git receive-pack fork >actual &&
>> extract_haves <actual >actual.haves &&
>> --
>> 2.19.1.1094.gd480080bf6
>>
>>
next prev parent reply other threads:[~2018-10-25 1:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 7:36 [PATCH 0/2] run-command: fix Unix PATH lookup Jeff King
2018-10-24 7:37 ` [PATCH 1/2] t5410: use longer path for sample script Jeff King
2018-10-24 8:53 ` Johannes Schindelin
2018-10-25 1:15 ` Junio C Hamano [this message]
2018-10-24 7:38 ` [PATCH 2/2] run-command: mark path lookup errors with ENOENT Jeff King
2018-10-24 9:01 ` Johannes Schindelin
2018-10-24 9:16 ` Jeff King
2018-10-24 9:25 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq5zxqn7xg.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).