git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Phillip Wood <phillip.wood@dunelm.org.uk>, git <git@vger.kernel.org>
Subject: Re: [PATCH] diff: fix --color-moved-ws=allow-indentation-change
Date: Tue, 11 Sep 2018 12:24:58 -0700	[thread overview]
Message-ID: <xmqq5zzbq1kl.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAGZ79kacqst9PVCzit_XpKYTHDC7VaKG_7OGoZyd3CtUxw74Cg@mail.gmail.com> (Stefan Beller's message of "Tue, 11 Sep 2018 11:40:12 -0700")

Stefan Beller <sbeller@google.com> writes:

> On Tue, Sep 11, 2018 at 11:16 AM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Stefan Beller <sbeller@google.com> writes:
>>
>> >>  [...] So this should be sufficient.
>> >
>> > Yup.
>> > Thanks for keeping track of this patch, as I lost track of it.
>> >
>> > thanks,
>> > Stefan
>>
>> So does the above exchange mean that
>> <20180904135258.31300-1-phillip.wood@talktalk.net> is ready to go
>> with your Acked-by?
>
> Acked-by: Stefan Beller <sbeller@google.com

Thanks.

> I thought this was implicit, would you be interested in a more formal
> communication for this, c.f.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n513
> sections 12 and 13.

It wasn't like I was explicitly asking for an ack because that
section tells us to do so in this case.  Rather, I didn't follow the
state of this patch, for which the original author of the recent
feature ended up saying "I lost track of it".

If a reviewer and/or an acker anticipates that I, who by definition
needs to know the final state of more topics than any single
individual contributor does, may not remember the state of each
individual topic, and tries to be a bit more explicit, our
communication may sometimes end up being extra redundant, but some
other times, doing so would reduce the need for one extra roundtrip.

If I need a clarification, I'll ask anyway, just like I did in this
case, so I do not think it is all that necessary to be rigidly
"formal", especially among list regulars.  Just a simple common
sense courtesy to try reducing each other's workload and memory
burden is probably sufficient.

Thanks.

      reply	other threads:[~2018-09-11 19:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 13:52 [PATCH] diff: fix --color-moved-ws=allow-indentation-change Phillip Wood
2018-09-04 18:08 ` Stefan Beller
2018-09-04 18:51   ` Phillip Wood
2018-09-11 10:05     ` Phillip Wood
2018-09-11 17:48       ` Stefan Beller
2018-09-11 18:16         ` Junio C Hamano
2018-09-11 18:40           ` Stefan Beller
2018-09-11 19:24             ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq5zzbq1kl.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).