git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] t0051: use "skip_all" under !MINGW in single-test file
Date: Wed, 02 Feb 2022 12:19:09 -0800	[thread overview]
Message-ID: <xmqq7dad10oy.fsf@gitster.g> (raw)
In-Reply-To: <220202.86zgn96oip.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 02 Feb 2022 20:44:16 +0100")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>>> This way TAP consumers like "prove" will show a nice summary when the
>>> test is skipped, e.g.:
>>
>> ... as opposed to?  A failure?  A different appearance of the log
>> message?  Something else?
>
> In "prove" we go from simply showing "ok":
>     
>     $ prove t0051-windows-named-pipe.sh
>     t0051-windows-named-pipe.sh .. ok   
>     All tests successful.
>     Files=1, Tests=1,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.03 cusr  0.01 csys =  0.06 CPU)
>     Result: PASS
>     
> To showing the skip message quoted here:

Because you have been here long enough, I trust that you already
know this, but for the benefit of those reading from sidelines...

As with many questions I give during my code review, this was not a
request:"I do not understand this---please explain it to me".  It
poined out the part in the proposed log message that future readers
of "git log" would be puzzled about and needs to be improved.

Thanks for a reply.




  reply	other threads:[~2022-02-02 20:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 20:35 [PATCH] t0051: use "skip_all" under !MINGW in single-test file Ævar Arnfjörð Bjarmason
2022-02-01 21:48 ` Junio C Hamano
2022-02-02 19:44   ` Ævar Arnfjörð Bjarmason
2022-02-02 20:19     ` Junio C Hamano [this message]
2022-02-04 13:42 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-02-08 13:40   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7dad10oy.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jeffhost@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).