git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] use `curl-config --cflags`
Date: Fri, 27 Mar 2020 15:12:06 -0700	[thread overview]
Message-ID: <xmqq7dz5e9c9.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200326080540.GA2200522@coredump.intra.peff.net> (Jeff King's message of "Thu, 26 Mar 2020 04:05:40 -0400")

Jeff King <peff@peff.net> writes:

> I was recently testing Git's behavior with respect to various versions
> of libcurl. So I built a one-off libcurl and installed it in /tmp/foo,
> but was surprised that:
>
>   make CURL_CONFIG=/tmp/foo/bin/curl-config
>
> didn't work, since we do run "$(CURL_CONFIG) --libs". This fixes it,
> along with a minor optimization to the existing "--libs" call.
>
>   [1/2]: Makefile: avoid running curl-config multiple times
>   [2/2]: Makefile: use curl-config --cflags
>
>  Makefile | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
>
> -Peff

Both patches made sense.  Thanks.

  parent reply	other threads:[~2020-03-27 22:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26  8:05 [PATCH 0/2] use `curl-config --cflags` Jeff King
2020-03-26  8:06 ` [PATCH 1/2] Makefile: avoid running curl-config multiple times Jeff King
2020-03-26  8:08 ` [PATCH 2/2] Makefile: use curl-config --cflags Jeff King
2020-03-27 22:12 ` Junio C Hamano [this message]
2020-04-04 13:38 ` [PATCH 0/2] use `curl-config --cflags` Johannes Schindelin
2020-04-04 14:58   ` [PATCH] Makefile: avoid running curl-config unnecessarily Jeff King
2020-04-05  1:33     ` Eric Sunshine
2020-04-05 18:44       ` Jeff King
2020-04-05 19:18         ` Eric Sunshine
2020-04-05 22:12       ` Johannes Schindelin
2020-04-05 22:12     ` Johannes Schindelin
2020-04-15 21:47     ` Junio C Hamano
2020-04-15 21:57       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7dz5e9c9.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).