From: Junio C Hamano <gitster@pobox.com>
To: Adam Dinwoodie <adam@dinwoodie.org>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Git Mailing List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
"Emily Shaffer" <emilyshaffer@google.com>
Subject: Re: [PATCH] t1800: correct test to handle Cygwin
Date: Tue, 13 Sep 2022 14:33:43 -0700 [thread overview]
Message-ID: <xmqq8rmn7ydk.fsf@gitster.g> (raw)
In-Reply-To: <CA+kUOa=DP6c417ZXXtxsJuyqJgpLZeAyr4URQPtMs0JhH1zVWQ@mail.gmail.com> (Adam Dinwoodie's message of "Tue, 13 Sep 2022 22:08:10 +0100")
Adam Dinwoodie <adam@dinwoodie.org> writes:
> ... It makes sense
> given the history of Git for Windows, but it's not a term many people
> are likely to be familiar with unless they've already been playing
> around with the MinGW/Cygwin environments, and I'm not sure that's a
> useful prerequisite for folk to be able to contribute to Git. I'm not
> sure what a better solution here might be; maybe retire "MINGW" and
> redefine "WINDOWS" to take its place, with current uses of "WINDOWS"
> being replaced with "WINDOWS || CYGWIN"?
It sounds more like "the world would've could've been a better place
if we did X", which is too late. As a non-Windows person, I think
the current approach is OK that assumes that those who write and
read to understand our tests can answer the question: "You're on
Windows? There are MINGW or CYGWIN, which one do you have?"
>> As Đoàn Trần Công Danh pointed out, the TODO: comment may need to be
>> updated. For future-proofing, perhaps "a more similar) error on all
>> platforms." would be appropriate.
>
> I'll respin with some updated comments shortly…
Thanks.
next prev parent reply other threads:[~2022-09-13 21:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 17:39 [PATCH] t1800: correct test to handle Cygwin Adam Dinwoodie
2022-09-01 18:32 ` Junio C Hamano
2022-09-02 1:55 ` Đoàn Trần Công Danh
2022-09-02 12:22 ` Johannes Schindelin
2022-09-07 20:49 ` Junio C Hamano
2022-09-07 20:57 ` rsbecker
2022-09-13 21:08 ` Adam Dinwoodie
2022-09-13 21:33 ` Junio C Hamano [this message]
2022-09-15 7:57 ` [PATCH v2] " Adam Dinwoodie
2022-09-15 8:51 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rmn7ydk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).