From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2 3/3] clone: use remote branch if it matches default HEAD
Date: Fri, 08 Jul 2022 09:28:00 -0700 [thread overview]
Message-ID: <xmqq8rp3wovj.fsf@gitster.g> (raw)
In-Reply-To: <YsdzZxS48u8sk9QD@coredump.intra.peff.net> (Jeff King's message of "Thu, 7 Jul 2022 19:59:35 -0400")
Jeff King <peff@peff.net> writes:
> + /*
> + * We may have selected a local default branch name "foo",
> + * and even though the remote's HEAD does not point there,
> + * it may still have a "foo" branch. If so, set it up so
> + * that we can follow the usual checkout code later.
Very sensible.
> + *
> + * Note that for an empty repo we'll already have set
> + * option_no_checkout above, which would work against us here.
> + * But for an empty repo, find_remote_branch() can never find
> + * a match.
> + */
> + our_head_points_at = find_remote_branch(mapped_refs, branch);
> +
> + if (!option_bare && !our_head_points_at)
> install_branch_config(0, branch, remote_name, ref);
I may be completely confused, but shouldn't the condition read "if
we are not bare, and we did find the 'branch' in their refs", i.e.
without "!" in front of our_head_points_at?
next prev parent reply other threads:[~2022-07-08 16:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 7:57 [PATCH 0/3] cloning unborn HEAD when other branches are present Jeff King
2022-07-06 8:00 ` [PATCH 1/3] clone: drop extra newline from warning message Jeff King
2022-07-06 8:00 ` [PATCH 2/3] clone: factor out unborn head setup into its own function Jeff King
2022-07-06 8:03 ` [PATCH 3/3] clone: propagate empty remote HEAD even with other branches Jeff King
2022-07-06 18:19 ` Junio C Hamano
2022-07-06 22:01 ` Junio C Hamano
2022-07-07 17:40 ` Jeff King
2022-07-07 18:50 ` Junio C Hamano
2022-07-07 23:54 ` [PATCH v2 0/3] cloning unborn HEAD when other branches are present Jeff King
2022-07-07 23:54 ` [PATCH v2 1/3] clone: drop extra newline from warning message Jeff King
2022-07-07 23:57 ` [PATCH v2 2/3] clone: propagate empty remote HEAD even with other branches Jeff King
2022-07-08 15:41 ` Junio C Hamano
2022-07-08 16:08 ` Jeff King
2022-07-07 23:59 ` [PATCH v2 3/3] clone: use remote branch if it matches default HEAD Jeff King
2022-07-08 16:28 ` Junio C Hamano [this message]
2022-07-08 19:30 ` Jeff King
2022-07-08 20:33 ` Junio C Hamano
2022-07-11 9:21 ` [PATCH v2 4/3] clone: move unborn head creation to update_head() Jeff King
2022-07-11 20:36 ` Junio C Hamano
2022-07-07 17:23 ` [PATCH 3/3] clone: propagate empty remote HEAD even with other branches Jeff King
2022-07-06 18:17 ` [PATCH 0/3] cloning unborn HEAD when other branches are present Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rp3wovj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).