archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: Johannes Schindelin <>
Cc: george espinoza via GitGitGadget <>,, George Espinoza <>
Subject: Re: [PATCH 1/1] [Outreachy] merge-ours: include parse-options
Date: Sat, 02 Nov 2019 13:14:44 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Johannes Schindelin's message of "Wed, 30 Oct 2019 22:58:39 +0100 (CET)")

Johannes Schindelin <> writes:

> Hi Junio,
> On Wed, 30 Oct 2019, Junio C Hamano wrote:
>> "george espinoza via GitGitGadget" <> writes:
>> > From: george espinoza <>
>> >
>> > Teach this command which currently handles its own argv to use
>> > parse-options instead because parse-options helps make sure we handle
>> > user input like -h in a standardized way across the project.
>> Sorry, but why do we even want to do this?
> It _is_ a command you can run via `git merge-ours` by mistake. Don't you
> think it would be nice for users to at least get a synopsis?

I think it would be good to tell users that the subcommand is not
what they want to run directly, instead of the synopsis to tell them
how to run it ;-).

So no.

But if merge-ours needs to learn its own -Xoption, it would make
sense to first convert it to use parse-options API and then add the
backend option support on top of it.  And the patch under discussion
in a polished form (by the way, has anybody pointed out that the use
of the verb "include" is a bit strange there on the patch title?)
would serve as a good first step for such a topic.


      reply	other threads:[~2019-11-02  4:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 23:42 [PATCH 0/1] [Outreachy] merge-ours: include a parse-option George Espinoza via GitGitGadget
2019-10-28 23:42 ` [PATCH 1/1] [Outreachy] merge-ours: include parse-options george espinoza via GitGitGadget
2019-10-29 12:56   ` Johannes Schindelin
2019-10-29 20:42   ` Emily Shaffer
2019-10-30  9:43     ` George Espinoza
2019-10-30  2:05   ` Junio C Hamano
2019-10-30  9:53     ` George Espinoza
2019-10-30 21:58     ` Johannes Schindelin
2019-11-02  4:14       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).