git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Tao Klerks <tao@klerks.biz>
Cc: git <git@vger.kernel.org>
Subject: Re: Defaulting --rebase-merges overall?
Date: Fri, 03 Feb 2023 13:09:59 -0800	[thread overview]
Message-ID: <xmqqa61uo3q0.fsf@gitster.g> (raw)
In-Reply-To: <CAPMMpoj6E-85a59EaHD2aR_oKA=_u78qRV+wp8mqXkR39KctmA@mail.gmail.com> (Tao Klerks's message of "Fri, 3 Feb 2023 19:19:00 +0100")

Tao Klerks <tao@klerks.biz> writes:

> 1. Change the "Need to specify how to reconcile divergent branches"
> pull conflict hint text to offer "git config pull.rebase merges"
> instead of "git config pull.rebase true"
> ...
> As I think about it, the global option sounds like it might be hard to
> prove the correctness of (and compatibility with the hosts of other
> options), so I probably won't be qualified to do this. Is there any
> objection to the simple hint change, at least?

I think suggesting "[pull] rebase = merges" is more in line with the
original spirit of suggesting "you want to recreate your work on top
of the updated upstream".

I do not particularly find it a good idea to suggest configuring
"git pull" to always rebase (whether it rebases with mergesor
flattens) in the first place, but if we were to offer such an option
anyway, "merges" is a much better choice than "true" to flatten,
simply because that matches the goal of "to recreate your work on
top of the updated upstream" better.

The only reason why 'true' is in the suggestion is because 'merges'
came much later than "when tried to pull and got a conflict, you'd
rebuild your work on top of theirs" suggestion was introduced.

      reply	other threads:[~2023-02-03 21:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 18:19 Defaulting --rebase-merges overall? Tao Klerks
2023-02-03 21:09 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa61uo3q0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=tao@klerks.biz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).