Git Mailing List Archive on lore.kernel.org
 help / color / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Charvi Mendiratta <charvi077@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
	phillip.wood123@gmail.com, congdanhqx@gmail.com, me@ttaylorr.com
Subject: Re: [PATCH v4] t7201: put each command on a separate line
Date: Tue, 20 Oct 2020 13:13:53 -0700
Message-ID: <xmqqa6wgbqpq.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201020121152.21645-1-charvi077@gmail.com> (Charvi Mendiratta's message of "Tue, 20 Oct 2020 17:41:52 +0530")

Charvi Mendiratta <charvi077@gmail.com> writes:

> Modern practice is to avoid multiple commands per line,
> and instead place each command on its own line.
>
> Signed-off-by: Charvi Mendiratta <charvi077@gmail.com>
> ---

This looks good, but I am wondering what happened between v3 and
v4.  

As you've demonstrated through the microproject that you can now
comfortably be involved in the review discussion, I am tempted to
suggest that we declare victory at this point and move on, but I
don't know what the plans are for the other 4 patches (I guess we
won't miss them that much---the micros are meant to be practice
targets).

Thanks.


>  t/t7201-co.sh | 26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/t/t7201-co.sh b/t/t7201-co.sh
> index 5898182fd2..b36a93056f 100755
> --- a/t/t7201-co.sh
> +++ b/t/t7201-co.sh
> @@ -157,7 +157,8 @@ test_expect_success 'checkout -m with merge conflict' '
>  '
>  
>  test_expect_success 'format of merge conflict from checkout -m' '
> -	git checkout -f master && git clean -f &&
> +	git checkout -f master &&
> +	git clean -f &&
>  
>  	fill b d >two &&
>  	git checkout -m simple &&
> @@ -180,7 +181,9 @@ test_expect_success 'format of merge conflict from checkout -m' '
>  '
>  
>  test_expect_success 'checkout --merge --conflict=diff3 <branch>' '
> -	git checkout -f master && git reset --hard && git clean -f &&
> +	git checkout -f master &&
> +	git reset --hard &&
> +	git clean -f &&
>  
>  	fill b d >two &&
>  	git checkout --merge --conflict=diff3 simple &&
> @@ -205,7 +208,9 @@ test_expect_success 'checkout --merge --conflict=diff3 <branch>' '
>  '
>  
>  test_expect_success 'switch to another branch while carrying a deletion' '
> -	git checkout -f master && git reset --hard && git clean -f &&
> +	git checkout -f master &&
> +	git reset --hard &&
> +	git clean -f &&
>  	git rm two &&
>  
>  	test_must_fail git checkout simple 2>errs &&
> @@ -218,7 +223,8 @@ test_expect_success 'switch to another branch while carrying a deletion' '
>  test_expect_success 'checkout to detach HEAD (with advice declined)' '
>  	git config advice.detachedHead false &&
>  	rev=$(git rev-parse --short renamer^) &&
> -	git checkout -f renamer && git clean -f &&
> +	git checkout -f renamer &&
> +	git clean -f &&
>  	git checkout renamer^ 2>messages &&
>  	test_i18ngrep "HEAD is now at $rev" messages &&
>  	test_line_count = 1 messages &&
> @@ -237,7 +243,8 @@ test_expect_success 'checkout to detach HEAD (with advice declined)' '
>  test_expect_success 'checkout to detach HEAD' '
>  	git config advice.detachedHead true &&
>  	rev=$(git rev-parse --short renamer^) &&
> -	git checkout -f renamer && git clean -f &&
> +	git checkout -f renamer &&
> +	git clean -f &&
>  	GIT_TEST_GETTEXT_POISON=false git checkout renamer^ 2>messages &&
>  	grep "HEAD is now at $rev" messages &&
>  	test_line_count -gt 1 messages &&
> @@ -254,7 +261,8 @@ test_expect_success 'checkout to detach HEAD' '
>  '
>  
>  test_expect_success 'checkout to detach HEAD with branchname^' '
> -	git checkout -f master && git clean -f &&
> +	git checkout -f master &&
> +	git clean -f &&
>  	git checkout renamer^ &&
>  	H=$(git rev-parse --verify HEAD) &&
>  	M=$(git show-ref -s --verify refs/heads/master) &&
> @@ -269,7 +277,8 @@ test_expect_success 'checkout to detach HEAD with branchname^' '
>  '
>  
>  test_expect_success 'checkout to detach HEAD with :/message' '
> -	git checkout -f master && git clean -f &&
> +	git checkout -f master &&
> +	git clean -f &&
>  	git checkout ":/Initial" &&
>  	H=$(git rev-parse --verify HEAD) &&
>  	M=$(git show-ref -s --verify refs/heads/master) &&
> @@ -284,7 +293,8 @@ test_expect_success 'checkout to detach HEAD with :/message' '
>  '
>  
>  test_expect_success 'checkout to detach HEAD with HEAD^0' '
> -	git checkout -f master && git clean -f &&
> +	git checkout -f master &&
> +	git clean -f &&
>  	git checkout HEAD^0 &&
>  	H=$(git rev-parse --verify HEAD) &&
>  	M=$(git show-ref -s --verify refs/heads/master) &&

  reply index

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 17:57 [PATCH 0/5][Outreachy] modernizing the test scripts charvi-077
2020-10-15 17:57 ` [PATCH 1/5][Outreachy] t7101,t7102,t7201: modernize test formatting charvi-077
2020-10-16 13:07   ` Christian Couder
2020-10-15 17:57 ` [PATCH 2/5][Outreachy] t7102,t7201: remove unnecessary blank spaces in test body charvi-077
2020-10-15 17:57 ` [PATCH 3/5][Outreachy] t7102,t7201: remove whitespace after redirect operator charvi-077
2020-10-15 17:57 ` [PATCH 4/5][Outreachy] t7201: avoid using cd outside of subshells charvi-077
2020-10-15 17:57 ` [PATCH 5/5][Outreachy] t7201: place each command in its own line charvi-077
2020-10-16 12:54 ` [PATCH 0/5][Outreachy] modernizing the test scripts Christian Couder
2020-10-17  8:27   ` Charvi Mendiratta
2020-10-17  7:54 ` [PATCH v2 " Charvi Mendiratta
2020-10-17  7:54   ` [PATCH v2 1/5][Outreachy] t7101,t7102,t7201: modernize test formatting Charvi Mendiratta
2020-10-17  7:54   ` [PATCH v2 2/5][Outreachy] t7102,t7201: remove unnecessary blank spaces in test body Charvi Mendiratta
2020-10-17 15:13     ` Đoàn Trần Công Danh
2020-10-18  5:40       ` Charvi Mendiratta
2020-10-17  7:54   ` [PATCH v2 3/5][Outreachy] t7102,t7201: remove whitespace after redirect operator Charvi Mendiratta
2020-10-17  7:54   ` [PATCH v2 4/5][Outreachy] t7201: avoid using cd outside of subshells Charvi Mendiratta
2020-10-18 15:39     ` Phillip Wood
2020-10-19 12:55       ` Charvi Mendiratta
2020-10-19 13:46         ` Phillip Wood
2020-10-19 17:24           ` Charvi Mendiratta
2020-10-19 20:25             ` Taylor Blau
2020-10-20  5:38               ` Charvi Mendiratta
2020-10-20 20:09                 ` Taylor Blau
2020-10-20  9:13               ` Phillip Wood
2020-10-20 11:48                 ` Charvi Mendiratta
2020-10-17  7:54   ` [PATCH v2 5/5][Outreachy] t7201: place each command in its own line Charvi Mendiratta
2020-10-20 11:43   ` [PATCH v3 0/5][Outreachy] modernize the test scripts Charvi Mendiratta
2020-10-20 11:43     ` [PATCH v3 1/5][Outreachy] t7101,t7102,t7201: modernize test formatting Charvi Mendiratta
2020-10-20 11:43     ` [PATCH v3 2/5][Outreachy] t7102,t7201: remove unnecessary blank spaces in test body Charvi Mendiratta
2020-10-20 11:43     ` [PATCH v3 3/5][Outreachy] t7102,t7201: remove whitespace after redirect operator Charvi Mendiratta
2020-10-20 11:43     ` [PATCH v3 4/5][Outreachy] t7201: use 'git -C' to avoid subshell Charvi Mendiratta
2020-10-20 11:43     ` [PATCH v3 5/5][Outreachy] t7201: put each command on a seperate line Charvi Mendiratta
2020-10-20 12:11   ` [PATCH v4] t7201: put each command on a separate line Charvi Mendiratta
2020-10-20 20:13     ` Junio C Hamano [this message]
2020-10-20 20:15       ` Taylor Blau
2020-10-20 20:25         ` Junio C Hamano
2020-10-20 20:30           ` Taylor Blau
2020-10-20 21:00             ` Junio C Hamano
2020-10-21  7:14             ` Charvi Mendiratta
2020-10-20 20:19       ` Junio C Hamano
2020-10-21 13:16         ` Charvi Mendiratta
2020-10-21 12:48     ` [PATCH v5 0/5][Outreachy] modernize the test scripts Charvi Mendiratta
2020-10-21 12:48       ` [PATCH v5 1/5][Outreachy] t7101,t7102,t7201: modernize test formatting Charvi Mendiratta
2020-10-21 12:48       ` [PATCH v5 2/5][Outreachy] t7102,t7201: remove unnecessary blank spaces in test body Charvi Mendiratta
2020-10-21 12:48       ` [PATCH v5 3/5][Outreachy] t7102,t7201: remove whitespace after redirect operator Charvi Mendiratta
2020-10-21 17:20         ` Eric Sunshine
2020-10-22  5:44           ` Junio C Hamano
2020-10-22  5:53             ` Eric Sunshine
2020-10-22  5:55             ` Junio C Hamano
2020-10-22  6:04               ` Eric Sunshine
2020-10-22 17:35                 ` Junio C Hamano
2020-10-22  6:29             ` Charvi Mendiratta
2020-10-21 12:48       ` [PATCH v5 4/5][Outreachy] t7201: use 'git -C' to avoid subshell Charvi Mendiratta
2020-10-21 12:48       ` [PATCH v5 5/5][Outreachy] t7201: put each command on a separate line Charvi Mendiratta
2020-10-22  7:16       ` [PATCH v6 0/5][Outreachy] modernize test scripts Charvi Mendiratta
2020-10-22  7:16       ` [PATCH v6 1/5][Outreachy] t7101,t7102,t7201: modernize test formatting Charvi Mendiratta
2020-10-22  7:16       ` [PATCH v6 2/5][Outreachy] t7102,t7201: remove unnecessary blank spaces in test body Charvi Mendiratta
2020-10-22  7:16       ` [PATCH v6 3/5][Outreachy] t7102,t7201: remove whitespace after redirect operator Charvi Mendiratta
2020-10-22  7:16       ` [PATCH v6 4/5][Outreachy] t7201: use 'git -C' to avoid subshell Charvi Mendiratta
2020-10-22  7:16       ` [PATCH v6 5/5][Outreachy] t7201: put each command on a separate line Charvi Mendiratta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa6wgbqpq.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=charvi077@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Mailing List Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/git/0 git/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 git git/ https://lore.kernel.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.git


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git