From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Markus Elfring <Markus.Elfring@web.de>, git@vger.kernel.org
Subject: Re: coccinelle: adjustments for array.cocci?
Date: Wed, 13 Nov 2019 11:11:38 +0900 [thread overview]
Message-ID: <xmqqa790cyp1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <5189f847-1af1-f050-6c72-576a977f6f12@web.de> (=?utf-8?Q?=22R?= =?utf-8?Q?en=C3=A9?= Scharfe"'s message of "Tue, 12 Nov 2019 19:37:23 +0100")
René Scharfe <l.s.r@web.de> writes:
> This reduces duplication in the semantic patch, which is nice. I think
> I tried something like that at the time, but found that it failed to
> produce some of the cases in 921d49be86 ("use COPY_ARRAY for copying
> arrays", 2019-06-15) for some reason.
Thanks for mentioning.
I too recall that seemingly redundant entries were noticed during
the review and at least back then removing the seemingly redundant
ones caused failures in rewriting.
That is why I am hesitant to touch any patch that says "simplify
cocci rule" making it sound as if simplification is a good thing on
its own. I have no problem with "we change the rule this way, which
eliminates this false positive / negative, that is demonstrated in
the added tests in t/ directory", though.
Thanks.
next prev parent reply other threads:[~2019-11-13 2:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 15:08 coccinelle: adjustments for array.cocci? Markus Elfring
2019-11-12 18:37 ` René Scharfe
2019-11-13 2:11 ` Junio C Hamano [this message]
2019-11-13 8:49 ` Markus Elfring
2019-11-14 2:03 ` Junio C Hamano
2019-11-14 13:15 ` Markus Elfring
2019-11-14 16:41 ` René Scharfe
2019-11-14 17:14 ` Markus Elfring
2019-11-14 17:46 ` René Scharfe
2019-11-15 11:11 ` git-coccinelle: " Markus Elfring
2019-11-15 14:20 ` Markus Elfring
2019-11-15 18:50 ` Markus Elfring
2019-11-16 1:00 ` [Cocci] " Julia Lawall
2019-11-16 6:57 ` Markus Elfring
2019-11-16 8:29 ` Markus Elfring
2019-11-16 17:57 ` Julia Lawall
2019-11-16 18:29 ` Markus Elfring
2019-11-15 20:37 ` coccinelle: " Markus Elfring
2019-11-16 21:13 ` René Scharfe
2019-11-17 7:56 ` Markus Elfring
2019-11-17 13:40 ` René Scharfe
2019-11-17 18:19 ` Markus Elfring
2019-11-19 19:14 ` René Scharfe
2019-11-19 20:21 ` Markus Elfring
2019-11-21 19:01 ` René Scharfe
2019-11-16 16:33 ` Markus Elfring
2019-11-16 21:38 ` René Scharfe
2019-11-17 8:19 ` Markus Elfring
2019-11-17 13:40 ` René Scharfe
2019-11-17 18:36 ` Markus Elfring
2019-11-19 19:15 ` René Scharfe
2019-11-18 16:10 ` [PATCH] coccinelle: improve array.cocci Markus Elfring
2019-11-19 19:15 ` René Scharfe
2019-11-20 9:01 ` Markus Elfring
2019-11-21 19:02 ` René Scharfe
2019-11-21 19:44 ` Markus Elfring
2019-11-22 15:29 ` SZEDER Gábor
2019-11-22 16:17 ` Markus Elfring
2019-11-22 5:54 ` [PATCH] " Junio C Hamano
2019-11-22 7:34 ` Markus Elfring
2020-01-25 8:23 ` Markus Elfring
2019-11-12 15:08 coccinelle: adjustments for array.cocci? Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa790cyp1.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Markus.Elfring@web.de \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).