archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: Stefan Beller <>
Subject: Re: [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id
Date: Thu, 06 Sep 2018 14:18:57 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Stefan Beller's message of "Wed, 5 Sep 2018 16:19:51 -0700")

Stefan Beller <> writes:

> All callers use oid_to_hex to convert the desired oid to a string before
> calling submodule_move_head. Defer the conversion to the
> submodule_move_head as it will turn out to be useful in a bit.
> Signed-off-by: Stefan Beller <>
> ---
> This is also part of the other series sent out yesterday, 

And what is your intention wrt the other one?

Do you want two separate copies of essentially the same patch queued
as part of two separate topics?  Did you change your mind since
yesterday and decided to retract these patches, and instead
concentrate on these two patches that address an issue with tigher
focus before moving on to other things?

Exactly the same comment applies to this copy.  It is somewhat
disturbing to see that new and old, which correspond to each other
and ought to be symmetrical, take the same "commit object" in
different shapes.

      parent reply	other threads:[~2018-09-06 21:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 23:19 [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id Stefan Beller
2018-09-05 23:19 ` [PATCH 2/2] submodule.c: warn about missing submodule commit in recursive actions Stefan Beller
2018-09-05 23:32   ` Jonathan Nieder
2018-09-06  6:22   ` Martin Ågren
2018-09-05 23:40 ` [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id Jonathan Nieder
2018-09-06 21:18 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).