git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Abhishek Kumar <abhishekkumar8222@gmail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2] commit-slab-decl.h: fix define guards
Date: Mon, 18 May 2020 10:32:49 -0700	[thread overview]
Message-ID: <xmqqblml408u.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cTFp0rHkYUwxvRJUWLBsV8gt-qL=UNVBB=+oTCkpe0oyA@mail.gmail.com> (Eric Sunshine's message of "Mon, 18 May 2020 13:29:08 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Mon, May 18, 2020 at 1:14 PM Junio C Hamano <gitster@pobox.com> wrote:
>> From: Abhishek Kumar <abhishekkumar8222@gmail.com>
>> Subject: [PATCH] commit-slab-decl.h: update include guard
>>
>> When a9f1f1f9f8 ("commit-slab.h: code split", 2018-05-19) split
>> commit-slab.h into commit-slab-decl.h and commit-slab-impl.h header
>> files, commit-slab-decl.h were left use "COMMIT_SLAB_HDR_H", while
>
> s/were left use/was left using/

Thanks, I meant to say "left to use" actually.



>> commit-slab-impl.h gained its own macro, "COMMIT_SLAB_IMPL_H".
>>
>> As these two files use different include guards, there is nothing
>> broken, but let's update commit-slab-decl.h to match the convention
>> to name the include guard after the filename.
>>
>> Signed-off-by: Abhishek Kumar <abhishekkumar8222@gmail.com>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>

      reply	other threads:[~2020-05-18 17:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16 17:28 [PATCH] commit-slab-decl.h: fix define gaurds Abhishek Kumar
2020-05-17 15:44 ` Junio C Hamano
2020-05-18 14:30 ` [PATCH v2] commit-slab-decl.h: fix define guards Abhishek Kumar
2020-05-18 17:12   ` Junio C Hamano
2020-05-18 17:29     ` Eric Sunshine
2020-05-18 17:32       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqblml408u.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=abhishekkumar8222@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).