git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] [RFC PATCH] stash save/push: add --index-only option
Date: Wed, 12 Feb 2020 21:04:30 -0800	[thread overview]
Message-ID: <xmqqblq3t6w1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAOc6etbkMJf9qSNMU4fD4KeHE6NuMRUuQf_cBos_oxuYwaaeAA@mail.gmail.com> (Edmundo Carmona Antoranz's message of "Wed, 12 Feb 2020 17:52:59 -0600")

Edmundo Carmona Antoranz <eantoranz@gmail.com> writes:

> On Wed, Feb 12, 2020 at 5:50 PM Edmundo Carmona Antoranz
> <eantoranz@gmail.com> wrote:
>>
>> Allow git-stash to save only the content of what's in staging area.
>> No working tree files (unstaged or untracked) will be added
>> to the stash nor will be modified then the opreration finishes.
>>
>
> Sorry for the double tag. This is not fully completed code. Wanted to
> know if the community thinks it's something worth developing and if
> I'm heading in the right direction in terms of the code that I'm
> hitting.

I am not sure if you explained how useful the "feature" being
proposed is, which is a very important skill to exercise to entice
readers to start reading and helping your code.

Why is it useful to be able to do this?  It is unclear at least to
me.

By the way, per "git help cli", the name for this new option that is
more in line with the rest of the system would be "--cached"; it
would tell Git to work only on the data in the index (as opposed to
the working tree files).
.


  reply	other threads:[~2020-02-13  5:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 23:50 [PATCH] [RFC PATCH] stash save/push: add --index-only option Edmundo Carmona Antoranz
2020-02-12 23:52 ` Edmundo Carmona Antoranz
2020-02-13  5:04   ` Junio C Hamano [this message]
2020-02-13 13:21     ` Edmundo Carmona Antoranz
2020-02-13 16:55       ` Junio C Hamano
2020-02-13 17:12         ` Edmundo Carmona Antoranz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqblq3t6w1.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=eantoranz@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).