git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH] t4014: shell portability fix
Date: Tue, 31 May 2016 15:53:15 -0700	[thread overview]
Message-ID: <xmqqbn3l3kmc.fsf@gitster.mtv.corp.google.com> (raw)

One-shot assignment to an environment variable, i.e.

	VAR=VAL cmd

does not work as expected for "cmd" that is a shell function on
certain shells.  test_commit _is_ a helper function and cannot be
driven that way portably.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t4014-format-patch.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
index 8049cad..c3aa543 100755
--- a/t/t4014-format-patch.sh
+++ b/t/t4014-format-patch.sh
@@ -1072,7 +1072,7 @@ test_expect_success '--from omits redundant in-body header' '
 '
 
 test_expect_success 'in-body headers trigger content encoding' '
-	GIT_AUTHOR_NAME="éxötìc" test_commit exotic &&
+	(export GIT_AUTHOR_NAME="éxötìc"; test_commit exotic) &&
 	test_when_finished "git reset --hard HEAD^" &&
 	git format-patch -1 --stdout --from >patch &&
 	cat >expect <<-\EOF &&

             reply	other threads:[~2016-05-31 22:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 22:53 Junio C Hamano [this message]
2016-05-31 22:56 ` [PATCH] t4014: shell portability fix Jeff King
2016-06-01  0:09   ` Eric Sunshine
2016-06-01  2:31     ` Jeff King
2016-06-01  3:31       ` Jeff King
2016-06-01  3:44         ` Jeff King
2016-06-01  3:54           ` Jeff King
2016-06-01  5:33           ` Jeff King
2016-06-01  5:40             ` Jeff King
2016-06-01  6:49               ` Junio C Hamano
2016-06-01  6:57                 ` Junio C Hamano
2016-06-01  7:04                 ` Jeff King
2016-06-01 15:07                   ` Junio C Hamano
2016-06-01 16:07                     ` Jeff King
2016-06-01 16:57                       ` Junio C Hamano
2016-06-01 16:58                         ` Jeff King
2016-06-01  5:48         ` Johannes Sixt
2016-06-01  5:48           ` Jeff King
2016-06-01  6:39       ` Eric Sunshine
2016-06-01  0:09 ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbn3l3kmc.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).