From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com,
kaartic.sivaraam@gmail.com, johannes.schindelin@gmx.de,
liu.denton@gmail.com, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test
Date: Wed, 05 Aug 2020 15:25:17 -0700 [thread overview]
Message-ID: <xmqqd044n31u.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200805210104.GH9546@syl.lan> (Taylor Blau's message of "Wed, 5 Aug 2020 17:01:04 -0400")
Taylor Blau <me@ttaylorr.com> writes:
>> test_expect_success '--for-status' "
>> git submodule summary --for-status HEAD^ >actual &&
>> - test_i18ncmp actual - <<EOF
>> + cat >expected <<-EOF &&
>> * sm1 $head6...0000000:
>>
>> * sm2 0000000...$head7 (2):
>> > Add foo9
>>
>> EOF
>> + test_i18ncmp expected actual
>> "
>
> I think that this is on the right track, but you can use a '<<-\EOF'
> here instead of '<<-EOF' to make the tabulation a little more flexible.
You are correct that the patch could have indented the here-doc and
the line with EOF with a tab to make it easier to read.
The leading '-' after '<<' is what controls tabulation, so <<-EOF as
written in the patch is good enough; you do not want to quote it
further, because $head6 wants to be interpolated.
next prev parent reply other threads:[~2020-08-05 22:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 17:49 [GSoC][RESEND][PATCH 0/4] t7401: modernize, cleanup and warn Shourya Shukla
2020-08-05 17:49 ` [PATCH 1/4] t7401: modernize style Shourya Shukla
2020-08-05 19:37 ` Denton Liu
2020-08-05 20:49 ` Taylor Blau
2020-08-06 8:45 ` Shourya Shukla
2020-08-05 17:49 ` [PATCH 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla
2020-08-05 20:58 ` Taylor Blau
2020-08-05 21:23 ` Junio C Hamano
2020-08-05 17:49 ` [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Shourya Shukla
2020-08-05 21:01 ` Taylor Blau
2020-08-05 22:25 ` Junio C Hamano [this message]
2020-08-05 22:26 ` Taylor Blau
2020-08-05 21:30 ` Junio C Hamano
2020-08-06 8:50 ` Shourya Shukla
2020-08-06 17:18 ` Junio C Hamano
2020-08-05 17:49 ` [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Shourya Shukla
2020-08-05 21:04 ` Taylor Blau
2020-08-05 21:36 ` Junio C Hamano
2020-08-06 11:27 ` Shourya Shukla
2020-08-06 21:11 ` Junio C Hamano
2020-08-07 14:55 ` Christian Couder
2020-08-12 19:27 ` [GSoC][PATCH v2 0/4] t7401: modernize, cleanup and more Shourya Shukla
2020-08-12 19:27 ` [PATCH v2 1/4] t7401: modernize style Shourya Shukla
2020-08-13 8:06 ` Kaartic Sivaraam
2020-08-13 16:46 ` Junio C Hamano
2020-08-14 14:41 ` Shourya Shukla
2020-08-14 17:06 ` Junio C Hamano
2020-08-12 19:27 ` [PATCH v2 2/4] t7401: change test_i18ncmp syntax for clarity Shourya Shukla
2020-08-12 20:57 ` Junio C Hamano
2020-08-12 21:02 ` Junio C Hamano
2020-08-14 14:57 ` Shourya Shukla
2020-08-12 19:27 ` [PATCH v2 3/4] t7401: change indentation for enhanced readability Shourya Shukla
2020-08-12 19:27 ` [PATCH v2 4/4] t7401: add a NEEDSWORK Shourya Shukla
-- strict thread matches above, loose matches on Subject: below --
2020-07-26 14:25 [GSoC][PATCH 0/4] t7401: modernize, cleanup and warn Shourya Shukla
2020-07-26 14:25 ` [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Shourya Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd044n31u.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kaartic.sivaraam@gmail.com \
--cc=liu.denton@gmail.com \
--cc=me@ttaylorr.com \
--cc=shouryashukla.oo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).