git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: Lukas Pupka-Lipinski <lukas.pupkalipinski@lpl-mind.de>,
	git@vger.kernel.org, pjwhams@gmail.com
Subject: Re: [PATCH] added: Multi line support for ignore-paths configuration
Date: Wed, 25 Mar 2020 14:24:37 -0700	[thread overview]
Message-ID: <xmqqd090w2ju.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200325203823.GA21913@dcvr> (Eric Wong's message of "Wed, 25 Mar 2020 20:38:23 +0000")

Eric Wong <e@80x24.org> writes:

> Lukas Pupka-Lipinski <lukas.pupkalipinski@lpl-mind.de> wrote:
>> From 01d4e4dbc4e524db6188f41904a7274d1582d066 Mon Sep 17 00:00:00 2001
>
> Hello Lukas and welcome to git hacker community!  It looks like
> your first patch, so some details to point out, most of which
> should be covered in `Documentation/SubmittingPatches'

Thanks, Lukas and Eric for an excellent review.

 Thanks, though S-o-b generally includes the full name, so:
>
>   Signed-off-by: Lukas Pupka-Lipinski <lukas.pupkalipinski@lpl-mind.de>
>
> is more appropriate

Yes.  The author identity and the "name <addr>" on Signed-off-by
line should match.


  reply	other threads:[~2020-03-25 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  6:56 Lukas Pupka-Lipinski
2020-03-25 20:38 ` Eric Wong
2020-03-25 21:24   ` Junio C Hamano [this message]
     [not found]   ` <0515a11b-d9ae-3f22-65a8-5efee235d5c9@lpl-mind.de>
2020-03-29 23:24     ` Eric Wong
     [not found]       ` <8fbfbf1c-ea14-6739-7881-cfa3d9642de9@lpl-mind.de>
2020-04-13 18:18         ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd090w2ju.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=lukas.pupkalipinski@lpl-mind.de \
    --cc=pjwhams@gmail.com \
    --subject='Re: [PATCH] added: Multi line support for ignore-paths configuration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).