From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C94C2BA83 for ; Thu, 13 Feb 2020 18:12:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E643C218AC for ; Thu, 13 Feb 2020 18:12:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="XluvkXDX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727789AbgBMSMX (ORCPT ); Thu, 13 Feb 2020 13:12:23 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:64442 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727683AbgBMSMX (ORCPT ); Thu, 13 Feb 2020 13:12:23 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 502963E549; Thu, 13 Feb 2020 13:12:22 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=EnX1OYatYM+49eQgv8WXyT39hSo=; b=XluvkX DX934J67vQQCzlFM6OrZxD8SGAC5+luTWhXT3wJI0VSjTKkWDEHwmpgoMk6K0vfk G3iAa/GfsDqgtkI1DoTTvnbPIObucwebQ3sBLIilSIafLi9KhQIgarW6E9fskfB1 g2WnxPBYMDaok1nE2T2o1PLLbQOnr1haX+pH8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=OnX9AUP3yaTn7bFeUI9P0iuRMzIewdRN KI9hbkol7bCaRbTxg8ohsTGm7Yhfxq4tsItrzPC8uLtvjaWRYHQ0+6puDXHN7dnj 6oOuJt8fgocgy8JwMYpSFDX8kPdR/uKCn64oUQJdqeaz1Lx0pGYDBo43nuW+uAKn MkWCpotryZA= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 48B4E3E548; Thu, 13 Feb 2020 13:12:22 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id A82363E547; Thu, 13 Feb 2020 13:12:21 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: git@vger.kernel.org Subject: Re: [PATCH 02/13] pack-bitmap: fix leak of haves/wants object lists References: <20200213021506.GA1124607@coredump.intra.peff.net> <20200213021633.GB1126038@coredump.intra.peff.net> Date: Thu, 13 Feb 2020 10:12:20 -0800 In-Reply-To: <20200213021633.GB1126038@coredump.intra.peff.net> (Jeff King's message of "Wed, 12 Feb 2020 21:16:33 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 60F14DDA-4E8C-11EA-8F64-C28CBED8090B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > When we do a bitmap-aware revision traversal, we create an object_list > for each of the "haves" and "wants" tips. After creating the result > bitmaps these are no longer needed or used, but we never free the list > memory. > > Signed-off-by: Jeff King > --- Obviously correct ;-)